eason9487
commented
2 weeks ago
- We've removed the Ads audience field from the onboarding form in #2501. Do we need to add it back as an optionally displayed field so it can be shown in the secondary flow?
This will depend on the changes to the shared components.
The changes planned for shared components are mentioned in the Implementation Brief, but given that the AdsCampaign component is also used by the CreatePaidAdsCampaign and EditPaidAdsCampaign components, it may not be better to move the sections from SetupPaidAds to AdsCampaign.
- The generic
AdsCampaigncomponent used in the paid ads-stepper is also used in pages for creating a campaign and editing a campaign. How are those two pages tested?
Currently, it relies heavily on manual testing.
joemcgill
asvinb
Part of https://github.com/woocommerce/google-listings-and-ads/issues/2460
When a merchant is setting up a new ads campaign from the plugin dashboard, they enter the "Set up paid campaign" flow, which includes individual steps for connecting a Google Ads account, configuring a campaign, and completing their billing setup.
Currently, the second step is where a merchant configures their campaign, including setting their targeted audience(s) and their daily budget.
We have a similar form on the last step of onboarding which is being simplified as part of #2458.
Maintaining two different components for this same action is redundant so we will consolidate on a single component that is used in both flows. However, the form displayed in the "Set up paid campaign" flow is also used when editing current campaigns, so the ability to set your audience will need to be optionally shown if we're editing a campaign.
## Acceptance Criteria - [ ] When a user is on the "Create your paid campaign" step of the "Set up paid ads" flow, they will see the same form used on the "Create a campaign" step of the "Get started..." onboarding flow. - [ ] The merchant can set their daily budget for their campaign - [ ] If a merchant hasn't set up billing for their Ads account, they will not be able to complete the form and the button will be disabled. - [ ] If a merchant hasn't set up billing, show the billing setup component - [ ] A user should be able to successfully set up billing from this form - [ ] Once billing is set up, the completion button should be enabled and the clicking should successfully create a campaign - [ ] When editing a campaign, the user should no longer see target audience fields, following #2501. - [ ] ~When editing a campaign, the user should be able to modify the target audiences~ (no longer applicable) ## Implementation Brief The PR should get merged into the [feature/2460-simplify-paid-ads-setup](https://github.com/woocommerce/google-listings-and-ads/tree/feature/2460-simplify-paid-ads-setup) branch. There is a generic component for setting up an ads campaign in `js/src/components/paid-ads/ads-campaign.js`, which returns a `StepContent` component. This component is used for both the `CreatePaidAdsCampaign` and `EditPaidAdsCampaign` pages. This component should be refactored to include the sections from the `SetupPaidAds` component in `js/src/setup-mc/setup-stepper/setup-paid-ads/setup-paid-ads.js` which is used in the onboarding flow, and that component should now consume the generic `AdsCampaign` component. The generic component should include the ability to pass a title and description to the `StepContentHeader` as props. It should render the `PaidAdsFeaturesSection` and `PaidAdsSetupSections` components from `js/src/setup-mc/setup-stepper/setup-paid-ads/`, both of which should be moved to the `js/src/components/paid-ads/ads-campaign/` folder. The generic component should support configuring two CTA buttons: a primary button that is required, and a secondary button which is optional (for the "Skip this step for now" CTA). We removed the Audience field from the onboarding flow in #2551, but it will need to be retained as a field that is only shown in the consolidated flow if we're editing a campaign. This will likely require a new boolean `isEditing` prop for the `AdsCampaign` component that can used to determine whether this field (and potentially others in the future) are shown. ## Test Coverage - E2E tests for tests/e2e/specs/setup-mc/step-4-complete-campaign.test.js should still pass without needing any functional changes. - E2E tests for tests/e2e/specs/add-paid-campaigns/add-paid-campaigns.test.js should be updated to account for the changes in this issue. ## Definition Questions - We've removed the Ads audience field from the onboarding form in [#2501](https://github.com/woocommerce/google-listings-and-ads/issues/2501). Do we need to add it back as an optionally displayed field so it can be shown in the secondary flow? - The generic `AdsCampaign` component used in the paid ads-stepper is also used in pages for creating a campaign and editing a campaign. How are those two pages tested?