search

woocommerce / google-listings-and-ads

Sync your store with Google to list products for free, run paid ads, and track performance straight from your store dashboard.
https://woo.com/products/google-listings-and-ads/
GNU General Public License v3.0
45 stars 21 forks source link

Consolidate Ad Creation #2575

Open asvinb opened 2 weeks ago

asvinb commented 2 weeks ago

Changes proposed in this Pull Request:

Closes #2535

Replace this with a good description of your changes & reasoning.

Screenshots:

Detailed test instructions:

Additional details:

Changelog entry

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 2.81690% with 69 lines in your changes missing coverage. Please review.

Project coverage is 62.4%. Comparing base (315fce2) to head (8e95434).

Files with missing lines Patch % Lines
js/src/components/paid-ads/ads-campaign/index.js 0.0% 39 Missing and 5 partials :warning:
...rc/components/paid-ads/ads-campaign/skip-button.js 0.0% 9 Missing and 2 partials :warning:
...s/paid-ads/ads-campaign/paid-ads-setup-sections.js 0.0% 6 Missing and 2 partials :warning:
...paid-ads/ads-campaign/paid-ads-features-section.js 0.0% 5 Missing and 1 partial :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2575/graphs/tree.svg?width=650&height=150&src=pr&token=UROWUPF1LX&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) ```diff @@ Coverage Diff @@ ## feature/2460-simplify-paid-ads-setup #2575 +/- ## ========================================================================= - Coverage 65.0% 62.4% -2.7% ========================================================================= Files 475 334 -141 Lines 17900 5226 -12674 Branches 0 1269 +1269 ========================================================================= - Hits 11640 3259 -8381 + Misses 6260 1781 -4479 - Partials 0 186 +186 ``` | [Flag](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2575/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [js-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2575/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `62.4% <2.8%> (?)` | | | [php-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2575/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2575?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [.../components/paid-ads/ads-campaign/clientSession.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2575?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fpaid-ads%2Fads-campaign%2FclientSession.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvcGFpZC1hZHMvYWRzLWNhbXBhaWduL2NsaWVudFNlc3Npb24uanM=) | `25.0% <ø> (ø)` | | | [.../src/components/paid-ads/ads-campaign/constants.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2575?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fpaid-ads%2Fads-campaign%2Fconstants.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvcGFpZC1hZHMvYWRzLWNhbXBhaWduL2NvbnN0YW50cy5qcw==) | `100.0% <100.0%> (ø)` | | | [js/src/pages/create-paid-ads-campaign/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2575?src=pr&el=tree&filepath=js%2Fsrc%2Fpages%2Fcreate-paid-ads-campaign%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL3BhZ2VzL2NyZWF0ZS1wYWlkLWFkcy1jYW1wYWlnbi9pbmRleC5qcw==) | `10.8% <ø> (ø)` | | | [js/src/pages/edit-paid-ads-campaign/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2575?src=pr&el=tree&filepath=js%2Fsrc%2Fpages%2Fedit-paid-ads-campaign%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL3BhZ2VzL2VkaXQtcGFpZC1hZHMtY2FtcGFpZ24vaW5kZXguanM=) | `9.4% <ø> (ø)` | | | [js/src/setup-ads/ads-stepper/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2575?src=pr&el=tree&filepath=js%2Fsrc%2Fsetup-ads%2Fads-stepper%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL3NldHVwLWFkcy9hZHMtc3RlcHBlci9pbmRleC5qcw==) | `100.0% <ø> (ø)` | | | [.../src/setup-mc/setup-stepper/saved-setup-stepper.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2575?src=pr&el=tree&filepath=js%2Fsrc%2Fsetup-mc%2Fsetup-stepper%2Fsaved-setup-stepper.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL3NldHVwLW1jL3NldHVwLXN0ZXBwZXIvc2F2ZWQtc2V0dXAtc3RlcHBlci5qcw==) | `87.8% <ø> (ø)` | | | [...paid-ads/ads-campaign/paid-ads-features-section.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2575?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fpaid-ads%2Fads-campaign%2Fpaid-ads-features-section.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvcGFpZC1hZHMvYWRzLWNhbXBhaWduL3BhaWQtYWRzLWZlYXR1cmVzLXNlY3Rpb24uanM=) | `0.0% <0.0%> (ø)` | | | [...s/paid-ads/ads-campaign/paid-ads-setup-sections.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2575?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fpaid-ads%2Fads-campaign%2Fpaid-ads-setup-sections.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvcGFpZC1hZHMvYWRzLWNhbXBhaWduL3BhaWQtYWRzLXNldHVwLXNlY3Rpb25zLmpz) | `2.1% <0.0%> (ø)` | | | [...rc/components/paid-ads/ads-campaign/skip-button.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2575?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fpaid-ads%2Fads-campaign%2Fskip-button.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvcGFpZC1hZHMvYWRzLWNhbXBhaWduL3NraXAtYnV0dG9uLmpz) | `0.0% <0.0%> (ø)` | | | [js/src/components/paid-ads/ads-campaign/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2575?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fpaid-ads%2Fads-campaign%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvcGFpZC1hZHMvYWRzLWNhbXBhaWduL2luZGV4Lmpz) | `0.0% <0.0%> (ø)` | | ... and [799 files with indirect coverage changes](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2575/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)