search

woocommerce / google-listings-and-ads

Sync your store with Google to list products for free, run paid ads, and track performance straight from your store dashboard.
https://woo.com/products/google-listings-and-ads/
GNU General Public License v3.0
45 stars 21 forks source link

Remove the accounts connection page from the Ads Setup flow. #2595

Open kt-12 opened 1 week ago

kt-12 commented 1 week ago

Changes proposed in this Pull Request:

Closes #2534.

Replace this with a good description of your changes & reasoning.

Screenshots:

After removal of accounts setup page. Screenshot 2024-09-09 at 09 11 26

Detailed test instructions:

  1. Delete gla_ads_setup_completed_at options.
  2. Go to dashboard, under Performance (Paid Campaigns) section click Add paid campaign
  3. You should not see the Setup accounts page as shown in the screenshot. Proceed with the other steps and see if you are able to create first paid campaign.

Additional details:

Changelog entry

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.3%. Comparing base (315fce2) to head (46fca31). Report is 114 commits behind head on develop.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2595/graphs/tree.svg?width=650&height=150&src=pr&token=UROWUPF1LX&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2595?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) ```diff @@ Coverage Diff @@ ## develop #2595 +/- ## ============================================ - Coverage 65.0% 63.3% -1.8% ============================================ Files 475 319 -156 Lines 17900 5082 -12818 Branches 0 1236 +1236 ============================================ - Hits 11640 3215 -8425 + Misses 6260 1697 -4563 - Partials 0 170 +170 ``` | [Flag](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2595/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [js-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2595/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `63.3% <100.0%> (?)` | | | [php-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2595/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2595?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [js/src/setup-ads/ads-stepper/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2595?src=pr&el=tree&filepath=js%2Fsrc%2Fsetup-ads%2Fads-stepper%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL3NldHVwLWFkcy9hZHMtc3RlcHBlci9pbmRleC5qcw==) | `100.0% <100.0%> (ø)` | | ... and [793 files with indirect coverage changes](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2595/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)