Open joemcgill opened 1 month ago
@joemcgill I've added the IB and do you think we need the confirmation modal? Right now, when you want to create a new Ads account, the TermsModal
is displayed which acts like a confirmation.
The IB has been written with the above in mind. Curious to hear your thoughts.
@asvinb Given that at the point where we are showing this UI the user has already accepted terms (prior to connecting their Google account in #2566), I don't think an additional terms modal is necessary. I do think we should have an AYS modal just to keep someone from accidentally clicking that button. I think this will make the UI more consistent between the two types of account as well.
Thanks @joemcgill . IB has been updated to reflect this.
One additional suggestion is that we not refer to the "are you sure" modal as a WarningModal
and instead call it something like ConfirmCreateModal
, since the main objective is to ensure the user meant to initiate the new account creation and provide extra context to help inform their decision.
I'm marking this as needs design until we can get confirmation for the "are you sure" modal text and the design for the UI while a new account is being created and will follow up with @fblascogarma and @michaeleleder.
WarningModal
has been renamed to ConfirmCreateModal
in the IB. Thanks @joemcgill
Everything else looks right to me. @eason9487 anything you'd add?
Once the new account is created and reclaimed, the card will show the new account as connected
The copy of "Create a new Google Ads account" in this status might need adjustment, like "Use another Google Ads account" or "Connect to a different Google Ads account". The same goes for the rest copy on the UI because it looks like it's still waiting to connect an account.
@eason9487 Maybe we can update the copy during implementation? cc @joemcgill
Good thinking, @eason9487. We'll need to add the ability to connect a different account for both the Ads and MC component after they're connected.
@asvinb What do you think about including that in the scope of this issue and #2604, respectively?
Sure thing @joemcgill . IB has been updated to account for the new button.
@asvinb thanks! @eason9487 can you look at this one again as well?
Looks good. Thanks for the updates!
Part of https://github.com/woocommerce/google-listings-and-ads/issues/2509
While connecting the store to Google Ads, a merchant may want to create a new account, even if they already have an existing Ads account associated with their Google account.
To support this, we will add a link below the account selector to kick off account creation.
Clicking this link should show an "Are you sure" modal, which lets them initiate account creation or cancel (screenshot shows an example of the Merchant Center modal, copy for the Ads modal TBD).
Once they confirm they want a new account, the account selector will replaced with a message that reads:
And the Connect button will be replaced by a loading spinner with the word "Creating..."
Once the account is created, we'll display the Claim you account UI:
Once the new account is created and reclaimed, the card will show the new account as connected
Acceptance Criteria
Implementation Brief
ConfirmCreateModal
component in the same folder as theConnectAds
component created in #2596.js/src/components/google-mc-account-card/warning-modal/index.js
with updated copy.⚠️ Are you sure you want to create a new Google Ads account?
You already have another Ads account associated with this Google account.
If you create a new Google Ads account, you will need to accept an invite to the account before it can be used.
[Yes, I want the new account] [Cancel]