woocommerce / google-listings-and-ads

Sync your store with Google to list products for free, run paid ads, and track performance straight from your store dashboard.
https://woo.com/products/google-listings-and-ads/
GNU General Public License v3.0
47 stars 21 forks source link

Streamline campaign setup: Update budget recommendation text #2629

Closed kt-12 closed 1 month ago

kt-12 commented 1 month ago

Changes proposed in this Pull Request:

Closes #2600 .

Text updated to reflect the change. Check screenshot.

Screenshots:

Multiple Counties selected Screenshot 2024-09-30 at 10 42 21

Single country selected Screenshot 2024-09-30 at 10 42 13

Detailed test instructions:

  1. On "Create your paid campaign" page select single country
  2. Check if the text change is reflected.
  3. Now select an additional country and see if the text is same as shown in the screenshot above.

Additional details:

Changelog entry

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.6%. Comparing base (24044c5) to head (b581d13). Report is 249 commits behind head on feature/2459-campaign-creation-flow.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2629/graphs/tree.svg?width=650&height=150&src=pr&token=UROWUPF1LX&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2629?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) ```diff @@ Coverage Diff @@ ## feature/2459-campaign-creation-flow #2629 +/- ## ======================================================================== - Coverage 64.7% 62.6% -2.1% ======================================================================== Files 793 319 -474 Lines 22967 5063 -17904 Branches 1231 1232 +1 ======================================================================== - Hits 14865 3171 -11694 + Misses 7929 1718 -6211 - Partials 173 174 +1 ``` | [Flag](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2629/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [js-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2629/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `62.6% <ø> (-<0.1%)` | :arrow_down: | | [php-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2629/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2629?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [...-ads/budget-section/budget-recommendation/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2629?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fpaid-ads%2Fbudget-section%2Fbudget-recommendation%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvcGFpZC1hZHMvYnVkZ2V0LXNlY3Rpb24vYnVkZ2V0LXJlY29tbWVuZGF0aW9uL2luZGV4Lmpz) | `4.0% <ø> (ø)` | | ... and [494 files with indirect coverage changes](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2629/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)
asvinb commented 1 month ago

LGTM @kt-12

ankitguptaindia commented 1 month ago

Changes Look good and working as expected. ✅

https://github.com/user-attachments/assets/acfcb78e-7ba7-43c5-97b0-a1f39e74dd69

kt-12 commented 1 month ago

@eason9487 I am unsure how those commits ended up here. This was not the case till after 10upCR. I have removed those commits. It's good for WooCr review now.