Closed puntope closed 4 weeks ago
I noticed a different behavior for simple products when the GTIN is already set to the same value or when it's set to a different one. Is that expected? if there are differences, it keeps the core GTIN but adds the G4W as SKU, while for the case where they're the same, it does not set SKU.
Hey @tomalec that's odd I was not able to reproduce this. Can you verify again or help me to reproduce this issue?
The expected behaviour is:
Plus, for variable ones, it didn't migrate the GTINs. The process job was executed.
The variables are required to process the Variations. I just added a tweak here because I notice I was processing only available variations (those with price set) Now I do get all the variations.
Notice the GTIN in the variable inventory is useless because we don't support GTIN in Variables. So you need to check each of the variations (they have their own GTIN fields in core part and G4W tab) .
Attention: Patch coverage is 0%
with 38 lines
in your changes missing coverage. Please review.
Project coverage is 65.4%. Comparing base (
a2c3654
) to head (02e6224
). Report is 10 commits behind head on add/support-core-gtin-field.
Hey @tomalec I addressed all your comments and questions. Can you follow up with another review?
Changes proposed in this Pull Request:
Closes part of #2616 as part of pcTzPl-2p2-p2.
This PR creates the logic for the Job responsible for the migration GTIN in batches for all the products.
Screenshots:
Detailed test instructions:
gla/jobs/migrate_gtin/create_batch
scheduled in WooCommerce - Status - Scheduled actionsgla/jobs/migrate_gtin/process_items
created with the product ids.Additional details:
In follow-up PRs I will add:
Changelog entry