woocommerce / google-listings-and-ads

Sync your store with Google to list products for free, run paid ads, and track performance straight from your store dashboard.
https://woo.com/products/google-listings-and-ads/
GNU General Public License v3.0
47 stars 21 forks source link

Paid Features Performance card #2646

Closed kt-12 closed 1 month ago

kt-12 commented 1 month ago

Changes proposed in this Pull Request:

Closes #2538 .

Replace this with a good description of your changes & reasoning.

Screenshots:

Detailed test instructions:

Additional details:

Changelog entry

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 64.9%. Comparing base (ac6e716) to head (d56f832).

Files with missing lines Patch % Lines
js/src/dashboard/summary-section/paid-features.js 12.5% 7 Missing :warning:
...rd/summary-section/paid-campaign-promotion-card.js 0.0% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2646/graphs/tree.svg?width=650&height=150&src=pr&token=UROWUPF1LX&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2646?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) ```diff @@ Coverage Diff @@ ## feature/2460-google-ads-value-prop #2646 +/- ## ======================================================================= + Coverage 62.7% 64.9% +2.2% - Complexity 0 4596 +4596 ======================================================================= Files 319 794 +475 Lines 5074 24343 +19269 Branches 1231 1226 -5 ======================================================================= + Hits 3180 15790 +12610 - Misses 1721 8381 +6660 + Partials 173 172 -1 ``` | [Flag](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2646/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [js-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2646/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `62.7% <11.1%> (-<0.1%)` | :arrow_down: | | [php-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2646/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `65.4% <100.0%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2646?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [google-listings-and-ads.php](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2646?src=pr&el=tree&filepath=google-listings-and-ads.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-Z29vZ2xlLWxpc3RpbmdzLWFuZC1hZHMucGhw) | `75.0% <ø> (ø)` | | | [src/Product/SyncerHooks.php](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2646?src=pr&el=tree&filepath=src%2FProduct%2FSyncerHooks.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-c3JjL1Byb2R1Y3QvU3luY2VySG9va3MucGhw) | `90.8% <100.0%> (ø)` | | | [...rd/summary-section/paid-campaign-promotion-card.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2646?src=pr&el=tree&filepath=js%2Fsrc%2Fdashboard%2Fsummary-section%2Fpaid-campaign-promotion-card.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2Rhc2hib2FyZC9zdW1tYXJ5LXNlY3Rpb24vcGFpZC1jYW1wYWlnbi1wcm9tb3Rpb24tY2FyZC5qcw==) | `0.0% <0.0%> (-9.1%)` | :arrow_down: | | [js/src/dashboard/summary-section/paid-features.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2646?src=pr&el=tree&filepath=js%2Fsrc%2Fdashboard%2Fsummary-section%2Fpaid-features.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2Rhc2hib2FyZC9zdW1tYXJ5LXNlY3Rpb24vcGFpZC1mZWF0dXJlcy5qcw==) | `12.5% <12.5%> (ø)` | | ... and [472 files with indirect coverage changes](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2646/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)
kt-12 commented 1 month ago

Closing in favour of https://github.com/woocommerce/google-listings-and-ads/pull/2650