Closed joemcgill closed 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 61.3%. Comparing base (
41f5513
) to head (a9f5530
). Report is 11 commits behind head on update/2602-sync-mc-address.
Thanks for the feedback, @asvinb! I've made a few updates to address your concerns and am going to go ahead and merge this into the main working branch to finish off the PR.
Changes proposed in this Pull Request:
Merges into #2653. See #2602.
This updates the approach for syncing the MC address started in #2653 to also bring consistency to the way the
StoreAddressCard
information is shown in the settings screen. After this PR, the UI to verify phone numbers is completely removed, as it is no longer a requirement for Google Ads accounts. The old flow for editing the address has been removed and theStoreAddressCard
is shown directly in the settings page, with the option to sync data to MC if needed, via the "Refresh to sync" button.Screenshots (Onboarding):
The store address is invalid (missing info)
The store address is not in sync with MC
The store address is in sync with MC (nothing is shown during onboarding in this scenario)
Screenshots (Settings):
The store address is not in sync with MC
The store address is invalid (missing info)
The store address is in sync with MC
Detailed test instructions:
Additional details:
Changelog entry