woocommerce / google-listings-and-ads

Sync your store with Google to list products for free, run paid ads, and track performance straight from your store dashboard.
https://woo.com/products/google-listings-and-ads/
GNU General Public License v3.0
47 stars 21 forks source link

Consolidate accounts onboarding: Remove contact phone and update the approach for syncing contact address #2661

Closed joemcgill closed 3 weeks ago

joemcgill commented 3 weeks ago

Changes proposed in this Pull Request:

Merges into #2653. See #2602.

This updates the approach for syncing the MC address started in #2653 to also bring consistency to the way the StoreAddressCard information is shown in the settings screen. After this PR, the UI to verify phone numbers is completely removed, as it is no longer a requirement for Google Ads accounts. The old flow for editing the address has been removed and the StoreAddressCard is shown directly in the settings page, with the option to sync data to MC if needed, via the "Refresh to sync" button.

Screenshots (Onboarding):

The store address is invalid (missing info)

Screenshot 2024-11-01 at 10 18 22 AM

The store address is not in sync with MC

Screenshot 2024-11-01 at 10 19 21 AM

The store address is in sync with MC (nothing is shown during onboarding in this scenario)

Screenshots (Settings):

The store address is not in sync with MC

Screenshot 2024-11-01 at 10 20 58 AM

The store address is invalid (missing info)

Screenshot 2024-11-01 at 10 21 49 AM

The store address is in sync with MC

Screenshot 2024-11-01 at 10 20 23 AM

Detailed test instructions:

Additional details:

Changelog entry

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.3%. Comparing base (41f5513) to head (a9f5530). Report is 11 commits behind head on update/2602-sync-mc-address.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2661/graphs/tree.svg?width=650&height=150&src=pr&token=UROWUPF1LX&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2661?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) ```diff @@ Coverage Diff @@ ## update/2602-sync-mc-address #2661 +/- ## ============================================================= - Coverage 62.7% 61.3% -1.5% ============================================================= Files 325 319 -6 Lines 5160 4956 -204 Branches 1265 1214 -51 ============================================================= - Hits 3237 3037 -200 + Misses 1746 1743 -3 + Partials 177 176 -1 ``` | [Flag](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2661/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [js-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2661/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `61.3% <ø> (-1.5%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2661?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [js/src/components/account-card/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2661?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Faccount-card%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvYWNjb3VudC1jYXJkL2luZGV4Lmpz) | `89.2% <ø> (-2.7%)` | :arrow_down: | | [js/src/utils/urls.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2661?src=pr&el=tree&filepath=js%2Fsrc%2Futils%2Furls.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL3V0aWxzL3VybHMuanM=) | `52.8% <ø> (+0.3%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2661/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)
joemcgill commented 3 weeks ago

Thanks for the feedback, @asvinb! I've made a few updates to address your concerns and am going to go ahead and merge this into the main working branch to finish off the PR.