Improve post-onboarding: Remove the word "Paid" from the plugin

[joemcgill]

Changes proposed in this Pull Request:

Closes #2664.

Screenshots:

Detailed test instructions:

1. Complete onboarding without creating a campaign
2. Review the CTA in the dashboard for creating a campaign
3. Create a paid campaign and review the UI when creating a campaign

Additional details:

Changelog entry

Tweak - Remove the word "Paid" from the plugin.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.6%. Comparing base (2c3f089) to head (10dc1c9). Report is 10 commits behind head on feature/2460-google-ads-value-prop.

Files with missing lines	Patch %	Lines
...src/components/paid-ads/asset-group/asset-group.js	0.0%	1 Missing :warning:

Additional details and impacted files

[](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2672?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) ```diff @@ Coverage Diff @@ ## feature/2460-google-ads-value-prop #2672 +/- ## ================================================================== Coverage 63.6% 63.6% ================================================================== Files 332 332 Lines 5210 5210 Branches 1265 1265 ================================================================== Hits 3315 3315 Misses 1718 1718 Partials 177 177 ``` | [Flag](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2672/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [js-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2672/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `63.6% <50.0%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2672?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [...rc/components/paid-ads/add-paid-campaign-button.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2672?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fpaid-ads%2Fadd-paid-campaign-button.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvcGFpZC1hZHMvYWRkLXBhaWQtY2FtcGFpZ24tYnV0dG9uLmpz) | `73.3% <100.0%> (ø)` | | | [...c/components/paid-ads/ads-campaign/ads-campaign.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2672?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fpaid-ads%2Fads-campaign%2Fads-campaign.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvcGFpZC1hZHMvYWRzLWNhbXBhaWduL2Fkcy1jYW1wYWlnbi5qcw==) | `0.0% <ø> (ø)` | | | [...-program-button/edit-program-prompt-modal/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2672?src=pr&el=tree&filepath=js%2Fsrc%2Fdashboard%2Fall-programs-table-card%2Fedit-program-button%2Fedit-program-prompt-modal%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2Rhc2hib2FyZC9hbGwtcHJvZ3JhbXMtdGFibGUtY2FyZC9lZGl0LXByb2dyYW0tYnV0dG9uL2VkaXQtcHJvZ3JhbS1wcm9tcHQtbW9kYWwvaW5kZXguanM=) | `10.0% <ø> (ø)` | | | [...e-card/program-toggle/pause-program-modal/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2672?src=pr&el=tree&filepath=js%2Fsrc%2Fdashboard%2Fall-programs-table-card%2Fprogram-toggle%2Fpause-program-modal%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2Rhc2hib2FyZC9hbGwtcHJvZ3JhbXMtdGFibGUtY2FyZC9wcm9ncmFtLXRvZ2dsZS9wYXVzZS1wcm9ncmFtLW1vZGFsL2luZGV4Lmpz) | `14.3% <ø> (ø)` | | | [...emove-program-button/remove-program-modal/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2672?src=pr&el=tree&filepath=js%2Fsrc%2Fdashboard%2Fall-programs-table-card%2Fremove-program-button%2Fremove-program-modal%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2Rhc2hib2FyZC9hbGwtcHJvZ3JhbXMtdGFibGUtY2FyZC9yZW1vdmUtcHJvZ3JhbS1idXR0b24vcmVtb3ZlLXByb2dyYW0tbW9kYWwvaW5kZXguanM=) | `7.1% <ø> (ø)` | | | [...dashboard/campaign-creation-success-guide/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2672?src=pr&el=tree&filepath=js%2Fsrc%2Fdashboard%2Fcampaign-creation-success-guide%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2Rhc2hib2FyZC9jYW1wYWlnbi1jcmVhdGlvbi1zdWNjZXNzLWd1aWRlL2luZGV4Lmpz) | `71.4% <ø> (ø)` | | | [js/src/pages/create-paid-ads-campaign/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2672?src=pr&el=tree&filepath=js%2Fsrc%2Fpages%2Fcreate-paid-ads-campaign%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL3BhZ2VzL2NyZWF0ZS1wYWlkLWFkcy1jYW1wYWlnbi9pbmRleC5qcw==) | `10.0% <ø> (ø)` | | | [js/src/pages/edit-paid-ads-campaign/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2672?src=pr&el=tree&filepath=js%2Fsrc%2Fpages%2Fedit-paid-ads-campaign%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL3BhZ2VzL2VkaXQtcGFpZC1hZHMtY2FtcGFpZ24vaW5kZXguanM=) | `8.6% <ø> (ø)` | | | [...src/product-feed/submission-success-guide/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2672?src=pr&el=tree&filepath=js%2Fsrc%2Fproduct-feed%2Fsubmission-success-guide%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL3Byb2R1Y3QtZmVlZC9zdWJtaXNzaW9uLXN1Y2Nlc3MtZ3VpZGUvaW5kZXguanM=) | `65.2% <ø> (ø)` | | | [js/src/setup-ads/ads-stepper/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2672?src=pr&el=tree&filepath=js%2Fsrc%2Fsetup-ads%2Fads-stepper%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL3NldHVwLWFkcy9hZHMtc3RlcHBlci9pbmRleC5qcw==) | `83.3% <ø> (ø)` | | | ... and [2 more](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2672?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | |

[joemcgill]

This is a quick one to update some UI text based on feedback from @fblascogarma during the review of #2460.

[joemcgill]

Thanks @mikkamp. I've addressed the two inline suggestions. For your other observations:

I noticed that when you click the edit campaign button the following popup is still shown which mentions a paid campaign:

Good catch. I'm not sure if we want to update the copy for these as well. I'll confirm with @fblascogarma.

I was also a bit confused about going through the onboarding and creating a campaign. I was expecting to be redirected to the dashboard at the following URL

The onboarding flow has ended with the user redirected to the Product Feed tab since at least this commit, so I assume that has been an intentional decision.

I wasn't able to confirm the E2E tests are still passing as it fails with a missing currency in the text. I don't see that being directly related to this PR, but possibly some of the dependent code changed this.

I'm unable to reproduce this E2E test failure. Just to be safe, I triggered another full test run here, which seems to be passing.

[fblascogarma]

Good catch @eason9487 ! Yes, please let's remove it from those places too. Thank you!!

[joemcgill]

The additional instances of 'paid' have been replaced in the last two commits.

In each case, I've tried to use my best judgement in when it was appropriate to replace the existing text with "Google Ads", "campaign(s)", based on the context in which they are found.

For example, in the EditProgramPromptModal that is shown when editing both Free listings and Google Ads, the existing text was (emphasis mine) "Results typically improve with time with Google’s Free Listing and paid ad campaigns". I've chosen to replace this with "Results typically improve with time with Google’s Free Listing and Google Ads campaigns" to avoid implying that Ad campaigns are also free.

@fblascogarma feel free to review all the changes and suggest any additional tweaks.

[joemcgill]

Updated based on feedback in https://github.com/woocommerce/google-listings-and-ads/pull/2672#pullrequestreview-2438194580 and this edit from @fblascogarma.

Cherry-picked a70da30 in order to E2E Tests and it looks like everything is passing, except for a known issue fixed in https://github.com/woocommerce/google-listings-and-ads/pull/2670.