search

woocommerce / google-listings-and-ads

Sync your store with Google to list products for free, run paid ads, and track performance straight from your store dashboard.
https://woo.com/products/google-listings-and-ads/
GNU General Public License v3.0
47 stars 21 forks source link

Add/order value condition for shipping phase 1 #2686

Open ianlin opened 12 hours ago

ianlin commented 12 hours ago

Changes proposed in this Pull Request:

Closes # .

Replace this with a good description of your changes & reasoning.

Screenshots:

Detailed test instructions:

Additional details:

Changelog entry

codecov[bot] commented 12 hours ago

Codecov Report

Attention: Patch coverage is 45.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 63.9%. Comparing base (c5e4dc3) to head (3857f5a). Report is 67 commits behind head on update/shippings-settings-phase-1.

Files with missing lines Patch % Lines
.../free-listings/setup-free-listings/form-content.js 0.0% 3 Missing and 1 partial :warning:
.../components/adaptive-form/adaptive-form-context.js 0.0% 3 Missing :warning:
...condition-section/order-value-condition-section.js 33.3% 2 Missing :warning:
...ng-rate-section/flat-shipping-rates-input-cards.js 0.0% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2686/graphs/tree.svg?width=650&height=150&src=pr&token=UROWUPF1LX&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2686?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) ```diff @@ Coverage Diff @@ ## update/shippings-settings-phase-1 #2686 +/- ## =================================================================== + Coverage 63.8% 63.9% +0.1% =================================================================== Files 323 324 +1 Lines 5134 5140 +6 Branches 1254 1255 +1 =================================================================== + Hits 3278 3286 +8 + Misses 1683 1680 -3 - Partials 173 174 +1 ``` | [Flag](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2686/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [js-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `63.9% <45.0%> (+0.1%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2686?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [...inimum-order-card/calculateValueFromGroupChange.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2686?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Forder-value-condition-section%2Fminimum-order-card%2FcalculateValueFromGroupChange.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvb3JkZXItdmFsdWUtY29uZGl0aW9uLXNlY3Rpb24vbWluaW11bS1vcmRlci1jYXJkL2NhbGN1bGF0ZVZhbHVlRnJvbUdyb3VwQ2hhbmdlLmpz) | `100.0% <ø> (ø)` | | | [...oupShippingRatesByCurrencyFreeShippingThreshold.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2686?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Forder-value-condition-section%2Fminimum-order-card%2FgroupShippingRatesByCurrencyFreeShippingThreshold.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvb3JkZXItdmFsdWUtY29uZGl0aW9uLXNlY3Rpb24vbWluaW11bS1vcmRlci1jYXJkL2dyb3VwU2hpcHBpbmdSYXRlc0J5Q3VycmVuY3lGcmVlU2hpcHBpbmdUaHJlc2hvbGQuanM=) | `100.0% <ø> (ø)` | | | [...n-section/minimum-order-card/minimum-order-card.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2686?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Forder-value-condition-section%2Fminimum-order-card%2Fminimum-order-card.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvb3JkZXItdmFsdWUtY29uZGl0aW9uLXNlY3Rpb24vbWluaW11bS1vcmRlci1jYXJkL21pbmltdW0tb3JkZXItY2FyZC5qcw==) | `96.0% <100.0%> (ø)` | | | [...-order-form-modals/add-minimum-order-form-modal.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2686?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Forder-value-condition-section%2Fminimum-order-card%2Fminimum-order-form-modals%2Fadd-minimum-order-form-modal.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvb3JkZXItdmFsdWUtY29uZGl0aW9uLXNlY3Rpb24vbWluaW11bS1vcmRlci1jYXJkL21pbmltdW0tb3JkZXItZm9ybS1tb2RhbHMvYWRkLW1pbmltdW0tb3JkZXItZm9ybS1tb2RhbC5qcw==) | `100.0% <ø> (ø)` | | | [...order-form-modals/edit-minimum-order-form-modal.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2686?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Forder-value-condition-section%2Fminimum-order-card%2Fminimum-order-form-modals%2Fedit-minimum-order-form-modal.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvb3JkZXItdmFsdWUtY29uZGl0aW9uLXNlY3Rpb24vbWluaW11bS1vcmRlci1jYXJkL21pbmltdW0tb3JkZXItZm9ybS1tb2RhbHMvZWRpdC1taW5pbXVtLW9yZGVyLWZvcm0tbW9kYWwuanM=) | `100.0% <ø> (ø)` | | | [...imum-order-form-modals/minimum-order-form-modal.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2686?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Forder-value-condition-section%2Fminimum-order-card%2Fminimum-order-form-modals%2Fminimum-order-form-modal.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvb3JkZXItdmFsdWUtY29uZGl0aW9uLXNlY3Rpb24vbWluaW11bS1vcmRlci1jYXJkL21pbmltdW0tb3JkZXItZm9ybS1tb2RhbHMvbWluaW11bS1vcmRlci1mb3JtLW1vZGFsLmpz) | `91.7% <ø> (ø)` | | | [.../minimum-order-form-modals/validateMinimumOrder.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2686?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Forder-value-condition-section%2Fminimum-order-card%2Fminimum-order-form-modals%2FvalidateMinimumOrder.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvb3JkZXItdmFsdWUtY29uZGl0aW9uLXNlY3Rpb24vbWluaW11bS1vcmRlci1jYXJkL21pbmltdW0tb3JkZXItZm9ybS1tb2RhbHMvdmFsaWRhdGVNaW5pbXVtT3JkZXIuanM=) | `100.0% <ø> (ø)` | | | [...der-card/minimum-order-input-control-label-text.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2686?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Forder-value-condition-section%2Fminimum-order-card%2Fminimum-order-input-control-label-text.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvb3JkZXItdmFsdWUtY29uZGl0aW9uLXNlY3Rpb24vbWluaW11bS1vcmRlci1jYXJkL21pbmltdW0tb3JkZXItaW5wdXQtY29udHJvbC1sYWJlbC10ZXh0Lmpz) | `100.0% <ø> (ø)` | | | [.../minimum-order-card/minimum-order-input-control.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2686?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Forder-value-condition-section%2Fminimum-order-card%2Fminimum-order-input-control.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvb3JkZXItdmFsdWUtY29uZGl0aW9uLXNlY3Rpb24vbWluaW11bS1vcmRlci1jYXJkL21pbmltdW0tb3JkZXItaW5wdXQtY29udHJvbC5qcw==) | `92.9% <100.0%> (ø)` | | | [...-condition-section/offer-free-shipping-checkbox.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2686?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Forder-value-condition-section%2Foffer-free-shipping-checkbox.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvb3JkZXItdmFsdWUtY29uZGl0aW9uLXNlY3Rpb24vb2ZmZXItZnJlZS1zaGlwcGluZy1jaGVja2JveC5qcw==) | `100.0% <100.0%> (ø)` | | | ... and [4 more](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2686?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | |

🚨 Try these New Features: