woocommerce / google-listings-and-ads

Sync your store with Google to list products for free, run paid ads, and track performance straight from your store dashboard.
https://woo.com/products/google-listings-and-ads/
GNU General Public License v3.0
47 stars 21 forks source link

Full screen merchant center set up screen/page #44

Closed jconroy closed 3 years ago

jconroy commented 3 years ago

Description:

Set up basic scaffolding for the merchant center set up screen/page

Upon clicking the "Get started" (or "Continue Setup") on the getting started page a full-page set up screen/page should be displayed

At the top left of the page will be a backlink with the text "< Get started with Google for eCommerce" - this will return the user to the getting started page

At the top right of the page will be a help link pointing to extension documentation (location to be confirmed).

The set up process will consist of 2 steps:

  1. Set up your accounts
  2. Configure your free listing

Each of these is essentially a tabbed content area (or equivalent approach).

Note - during development, we may need to fake some of this logic initially (or options etc.) to avoid being blocked - actual functionality can be added as it is finalised.


Screenshots

Step 1

Screen Shot 2020-11-03 at 11 03 08 am

Step 2

Screen Shot 2020-11-03 at 11 02 49 am


Technical


Acceptance criteria:


Dependencies

Out of bounds/rabbit holes

Event tracking:

tomalec commented 3 years ago

For the full-page architecture/dev setup, I'd take inspiration from http://wptest.local/wordpress/wp-admin/admin.php?page=wc-admin&path=%2Fsetup-wizard Screenshoot from "Welcome to WooCommerce wizard" page

For the UX/UI, I was thinking of re-using the Modal component, to improve consistency in UX by using the single component for an interface element that overlays the rest of the screen (WP-admin chrome, with sidebar, etc).

It could be stretched to 100%, with "< Get started with Google for eCommerce" acting as a "close" button, with isDismissible: false, shouldCloseOnEsc: false, shouldCloseOnClickOutside: false.

tomalec commented 3 years ago

It seems that the WP-admin's wizard is not quite re-usable yet, and very Profile specific. I'd try to come up with a more generic full-page wizard component, that could be used here and eventually there, to hopefully serve a consistent User- and Developer Experience.

jconroy commented 3 years ago

For the full-page architecture/dev setup, I'd take inspiration from http://wptest.local/wordpress/wp-admin/admin.php?page=wc-admin&path=%2Fsetup-wizard

I think that is the best thing we have to take inspiration from 👍

I'd try to come up with a more generic full-page wizard component, that could be used here and eventually there, to hopefully serve a consistent User- and Developer Experience.

Sounds great 🙇 just be conscious of balancing time investment in terms of making something that works for us to meet deadlines vs spending a lot of time architecting something to be super reusable.


Based on our slack convos I've pushed up some example code for setting up some "pages" similar to the onboarding wizard https://github.com/woocommerce/google-listings-and-ads/tree/menus

ecgan commented 3 years ago

@tomalec ,

For the UX/UI, I was thinking of re-using the Modal component, to improve consistency in UX by using the single component for an interface element that overlays the rest of the screen (WP-admin chrome, with sidebar, etc).

Do you mean putting the merchant center setup wizard into the Modal component? Personally I thought it's going to be a full page wizard like the "Welcome to WooCommmerce" setup wizard, not in a Modal.

tomalec commented 3 years ago

just be conscious of balancing time investment

Good point thanks. I just came from Web Components world, where extracting full-page layout and behavior to a separate component, like

<full-screen-wizard>
  <h1 slot="header"><a>‹ Get started with Google for eCommerce</a></h1>
  <a slot="corner-menu">Help</a>
  <wp-stepper></wp-stepper>
  <div>...steps...</div>
</full-screen-wizard>

would be faster and easier.

I hope, I'll learn the React content distribution and alternatives soon enough.


Based on our slack convos I've pushed up some example code for setting up some "pages" similar to the onboarding wizard menus

Thanks 👍

tomalec commented 3 years ago

Do you mean putting the merchant center setup wizard into the Modal component? Personally I thought it's going to be a full page wizard like the "Welcome to WooCommmerce" setup wizard, not in a Modal.

Fair point. The more I look into the setup wizard, the more I feel Modal was a bad idea. I was mostly thinking of the experience of a user that clicks "Get Started" button, and suddenly the WP chrome disappears. I thought modal-like transition, like an animation of a window asking over the screen, would be comforting.

In a slack conversation, @j111q suggested that for such wizard screen, the menus could slide away to the top and left respectively.

However, at this point, given, we do not have enough building blocks ready, and time pressing, such considerations and tweaks are overkill nice to haves.

ecgan commented 3 years ago

@tomalec ,

I was mostly thinking of the experience of a user that clicks "Get Started" button, and suddenly the WP chrome disappears.

I share the same opinion with you that it looks jarring and not a good experience.

Yeah, we can look into that in the future.

jconroy commented 3 years ago

for such wizard screen, the menus could slide away to the top and left respectively.

That sounds amazing ❤️ 😍 but like you say @tomalec I don't believe we have enough building blocks or prior art within WordPress or Woo for that sort of thing atm. I think for now it's best to stick with the onboarding and WCPay approaches for now.

jconroy commented 3 years ago

would be faster and easier.

Definitely not opposed to it, just wanted to provide some guidance if it's looking like something that would take a bunch of time 👍

ecgan commented 3 years ago

@jconroy , want to double check with you, I guess it's fine to close this issue? Or is there anything else that we should keep this issue open?

jconroy commented 3 years ago

I think we're good to close this one