woocommerce / grow

7 stars 7 forks source link

Upgrade the root dependencies and setup to use Node.js v20 #113

Closed eason9487 closed 4 months ago

eason9487 commented 4 months ago

Changes proposed in this Pull Request:

Part of #108

This PR:

💡 These workflows depend on the release version, woocommerce/grow/<action_name>@actions-v1, so they will be upgraded after the @actions-v2 is published.

Detailed test instructions:

  1. JS linter
    • Use Node.js v20
    • npm install
    • npm run lint:js to see if the linter can be run and if the linting can pass
      • There may be some import/no-unresolved warnings. This kind of warnings can be ignore because the packages of sub-packages may not be installed.
    • Repeat this test with Node.js v18
  2. Inspect the "Publish Compat Checker package" workflow
    • The current s0/git-publish-subdir-action@develop revision already uses Node.js v20
    • The last workflow run shows the following warning. The warning should be fixed after c8606e5865fac626cf646a0ed1d4adc4e53733ca image
eason9487 commented 4 months ago

I will be skipping the code review process as it can be optional for a devs-facing only change.