woocommerce / grow

7 stars 7 forks source link

Upgrade the `merge-trunk-develop-pr`, `prepare-extension-release`, and `publish-extension-dev-build` actions to use Node.js v20 #121

Closed eason9487 closed 5 months ago

eason9487 commented 5 months ago

Changes proposed in this Pull Request:

Part of #108

This PR upgrades the merge-trunk-develop-pr, prepare-extension-release, and publish-extension-dev-build actions to use Node.js v20.

📌 Checklist before merging (@eason9487)

Detailed test instructions:

prepare-extension-release action

  1. View a previous workflow run used v1 action
  2. View a test workflow run used updated action
  3. View the new release PR created by this action

merge-trunk-develop-pr action

  1. View a previous workflow run used v1 action
  2. View a test workflow run used updated action
  3. View the merging back PR created by this action

publish-extension-dev-build action

  1. View a previous workflow run used v1 action
  2. View a test workflow run used updated action
  3. View the dev build published by this action
eason9487 commented 5 months ago

Thanks for the review, @mikkamp

I was just curious about us running on ubuntu-latest. Release date of 24.04 is today, doesn't look like it's changed yet, but do we expect that to switch over without issues?

I think this is the expected way - these actions are continuously compatible with the ubuntu-latest in GitHub Actions Runner. Most of the actions depend on Node.js, PHP or the common CLI, so as long as these dependencies are consistently compatible with ubuntu-latest, there should be no problems.

I guess we can handle that separately if something does go wrong.

Yes, a few actions depend on more particular CLI, such as jq, or services that are more prone to major changes, such as MySQL. I suppose we could just deal with it when it happens.