search

woocommerce / grow

7 stars 7 forks source link

Adjust the v1 of the `github-actions` package to be deprecated #124

Closed eason9487 closed 4 months ago

eason9487 commented 4 months ago

Changes proposed in this Pull Request:

Part of #108

This PR:

Detailed test instructions:

This PR involves the release processing of the github-actions package. It can only be verified after merging it to source/actions-v1. Therefore, I tested it with a forked repo.

  1. View the merged commit that has the same commit as this PR.
  2. View the workflow that prepares the PR for releasing version 1.11.3.
  3. View the workflow that publish the new release after approving the release PR.
  4. View the workflow that creates the build for v1.11.3 and updates tags.
  5. View the Tags page. The actions-v1, actions-v1.11, and actions-v1.11.3 tags were created and pointed to the same revision.
  6. Read the updated README to see if it is clear enough.
tomalec commented 4 months ago

Read the updated README to see if it is clear enough.

After the changes from this PR the packages/github-actions/README.md will not cover releasing a new major version. For the upcoming v2 version, do you plan to remove the changes to README.md from this PR? Leaving 1.x.y patch release instruction only at source/actions-v1? Would you stack them so that for v2, we'll see both ways? Or is the plan to remove major release instructions completely, as they are more complicated?

Or is the idea to keep source/actions-v1 branch away from trunk?

eason9487 commented 4 months ago

Hi @tomalec, thanks for the review!

Or is the idea to keep source/actions-v1 branch away from trunk?

Assuming, I understood correctly the release process split, and we'll keep source/actions-v1 as a separate branch & not plan to merge it into trunk

Yes! I set the source/actions-v1 as a protected branch and it will be kept and not be merged into trunk.