woocommerce / grow

7 stars 7 forks source link

Add versioning branches or tags #5

Open puntope opened 2 years ago

puntope commented 2 years ago

User story

As a developer I want to refer to this repo using versioned tags instead of "trunk" branch.

How to reproduce the problem

For referring to this repo we should add the branch trunk.

Describe the solution you'd like

Use a release version like WooCommerce or other repos in do.

Acceptance criteria

tomalec commented 2 years ago

WDYT of using Nx (to be consistent with woocommerce/woocommerce stack) and https://github.com/jscutlery/semver plugin? So we could simply do something like:

nx run storybook:version --releaseAs=minor

To do version bumps, git commit, tag (storybook@1.2.3) & push

puntope commented 2 years ago

WDYT of using Nx (to be consistent with woocommerce/woocommerce stack)

I guess is same as NPX? Glad to use it, looks cool and I wanted to give it a go for a long time. So 👍 for it

and https://github.com/jscutlery/semver plugin?

Never used it. (Neither heard about it) Wouldn't be enough with git flow?

tomalec commented 2 years ago

I guess is same as NPX?

not really npx (at least the one I know of) is an npm package that gives a command to execute binaries. While Nx is a rather big tool to setup a monorepo workflows.

Wouldn't be enough with git flow?

I don't think git flow works for monorepos out of the box. But maybe there is a way to use git flow directly with Nx. I don't know, As I've never used Nx or jscutlery/semver

tomalec commented 2 years ago

Maybe we can wait with Nx setup for https://github.com/woocommerce/woocommerce/pull/33079 as if Woo will move away to another tool, I'd use here the same.