search

woocommerce / grow

7 stars 7 forks source link

Dismissable notices from Compat Checker should be removed on plugin deactivation #94

Closed ibndawood closed 5 months ago

ibndawood commented 9 months ago

Describe the bug:

The Compat Checker framework adds dismissable notices using the WC_Admin_Notices class. These notices appear even after the plugin is deactivated.

Steps to reproduce:

  1. In the plugin header of the plugin that uses compat checker, set the WC tested upto header value to a version lower than the currently active WooCommerce.
  2. This should trigger a notice saying This plugin is not tested with this version of WooCommerce
  3. De-activate the plugin that uses compat checker.
  4. Notice the warning notice triggered in step 2 still appears.

Expected behavior:

All notices added by the plugin should be removed on de-activation.

Actual behavior:

Notices appear even after the deactivation of the plugin.