search

woocommerce / pinterest-for-woocommerce

A native Pinterest integration for WooCommerce. Development is managed by Ventures.
https://woocommerce.com/products/pinterest-for-woocommerce/
GNU General Public License v3.0
22 stars 9 forks source link

Fix tooltip UI issue in Settings page #986

Closed ecgan closed 5 months ago

ecgan commented 5 months ago

Changes proposed in this Pull Request:

Closes https://github.com/woocommerce/pinterest-for-woocommerce/issues/985.

In this PR, we fix the tooltip UI issue in Settings page. The code fix is based on tooltip code from WordPress 6.3.

I have also removed the tooltip for the "Sync" button at the top of the page, because I couldn't find an easy fix for it, and the help text does not seem to be really helpful as the "Sync" button is quite self explanatory.

Screenshots:

image

Detailed test instructions:

  1. Go to Settings page: /wp-admin/admin.php?page=wc-admin&path=%2Fpinterest%2Fsettings
  2. Hover your mouse cursor over the "Sync" link button at the top of the page. There should be no tooltip help text displayed.
  3. Hover your mouse cursor over the "?" tooltip icon.
  4. The tooltip help text should be displayed in a popover. The text should be readable.
ecgan commented 5 months ago

Putting this PR on-hold (don't merge it). This PR should be merged after we confirm that the version 1.4.0 with Pinterest v5 API changes are all stable.

Reference: p1712579162171969/1712578878.033089-slack-CK365S85V (cc @budzanowski, let me know when it is fine to merge this. 🙏 )

budzanowski commented 5 months ago

We can merge now :) It looks like we can merge anything.