woocommerce / qit-cli

A Testing Platform for WordPress Plugins and Themes
https://qit.woo.com
16 stars 2 forks source link

Use Composer CA Bundle instead of custom implementation #139

Closed Luc45 closed 6 months ago

Luc45 commented 6 months ago

Turns out that Composer also faced the SSL issue we faced on Windows and released their solution as a small package.

This PR removes our custom implementation of the fix, which works, to use Composer's instead, which is more robust, has been battle-tested trillions of times, and has the advantage that it works without asking the user if he wants to download the CA file. I've debated bundling the CA file instead of downloading it, but I didn't want to keep it updated, that's why I decided to ask the user to download it at runtime, but since this is handled by the package for us, then it's better.

Relevant links:

Luc45 commented 6 months ago

We can see on QIT Windows workflows that it used the bundled cert

image

I've tested on a Windows laptop and it also worked.