woocommerce / qit-cli

A Testing Platform for WordPress Plugins and Themes
https://qit.woo.com
15 stars 2 forks source link

Set Result Dir using ENV vat #194

Closed MrJnrman closed 1 month ago

MrJnrman commented 1 month ago

Based on our slack discussion @Luc45. This PR allows us to specify the results for the e2e tests using a RESULT_DIR env var.

Testing instructions

  1. Checkout this branch
  2. Run the following command and confirm that the results gets added to a temporary directory. php ./src/qit-cli.php run:e2e woocommerce-amazon-s3-storage ./<e2e-directory>
  3. Run the following command and confirm that the results get added to the directory specified. RESULTS_DIR="./results" php ./src/qit-cli.php run:e2e woocommerce-amazon-s3-storage ./<e2e-directory>
MrJnrman commented 1 month ago

Approved, I'd just prefix it with QIT_ to be explicit.

Done in 31f501b

Luc45 commented 1 month ago

@MrJnrman do a make build and push to trunk please :)