search

woocommerce / qit-cli

A Testing Platform for WordPress Plugins and Themes
https://qit.woo.com
15 stars 2 forks source link

Fix --source option #196

Closed Luc45 closed 3 weeks ago

Luc45 commented 3 weeks ago

This PR fixes the --source option on run:e2e as discussed in Slack.

MrJnrman commented 3 weeks ago

Thanks for working on this @Luc45. It works great with absolute paths, but not with relative paths. Maybe we can pass the source through realpath when setting up the volumes here https://github.com/woocommerce/qit-cli/blob/9d76f3006ac58a4a908e790d58a46097e303b3ff/src/src/Environment/ExtensionDownload/ExtensionDownloader.php#L92