search

woocommerce / selectWoo

selectWoo is a fork of select2 with improved accessibility.
MIT License
124 stars 27 forks source link

Upstream merge #17

Closed vedanshujain closed 6 years ago

vedanshujain commented 6 years ago

New changes from https://github.com/select2/select2

claudiulodro commented 6 years ago

This has lost a lot of the screen reader support which was the main reason for selectWoo. To test, you can use VoiceOver on Safari and modify the docs/accessibility-testing/samples examples to load up this version.

I think a better strategy would be to contribute the accessibility tweaks back to select2 so that everyone gets the benefits of them. I have capabilities on the select2 repo if you'd like to give it a shot, but it's not going to be easy.

Is there a reason you need the super-latest version? This is essentially the same as select2 v4.0.4 but with better accessibility, and it looks like many of the changes you are trying to merge are for the 4.0.6 release candidate (so you probably don't want to run those on production yet anyways).

vedanshujain commented 6 years ago

Yeah, ideally I want to have this fork updated before contributing these patches back to select2. I will take a look at this again sometime this week, see if I can fix the regressions. Always good to have the latest version.

vedanshujain commented 6 years ago

Closing in favor of #19