search

woocommerce / sensei-content-drip

A content drip extension for Sensei.
GNU General Public License v2.0
19 stars 6 forks source link

Remove lesson access #222

Closed gaurav1984 closed 3 years ago

gaurav1984 commented 3 years ago

The user contacted us at 3925282-zen, and they are looking to do the following

Steps to Reproduce

What I Expected

I checked this workflow on my test website and was able to reproduce the issue.

3925282-zd-woothemes

gaurav1984 commented 3 years ago

The user also has tried the following

The result is that once you have already had access to a lesson and then we don't want you to have access to that lesson you can always access it again regardless of the Drip Schedule

renatho commented 3 years ago

I was exploring it to reproduce the issue, but I'm not able to. What I did:

  1. Create a lesson with a drip schedule "A specific interval after the course start date" / "1" / "Day(s)".
  2. Enroll the learner in the course, and make sure they still don't have access.
  3. Go to the Learner Management, and "Manage learners" for the enrolled course.
  4. Edit the enrollment date to be sooner (a date that they would already gain the drip access).
  5. Make sure now the learner has access.
  6. Update the course enrollment date again to later (a date that they wouldn't have the drip access).
  7. Test with the learner and confirm they don't have access again.

An exception is when the learner completed the lesson when they had access. In this case, I went to the lesson in Learner Management and clicked on "Reset Progress" (besides the previously mentioned steps).

Everything worked as expected for me. Is there something I'm missing here?

They have a course set up with lessons access given after 7 days of completing the previous lesson

Maybe is there some confusion based on this? Because AFAIK we can't set up it based on the previous lesson completion, but we can make it based on the course starting date. Reading the ticket, I think the user set up based on the course starting date.

enwiss commented 3 years ago

Hi

The steps to reproduce the error are

  1. We create a course with two lessons
  2. Lesson two is named Drip Shedule "After two weeks"
  3. The student begins the course with lesson 1/4, ends it, marks "Complete Lesson"
  4. Two weeks pass and lesson 2/4 is activated.
  5. At this time we as administrators no longer believe it is appropriate for the student to start this lesson and we want him to only have access to lesson 1/4 and not yet be able to access lesson 2/4.
  6. At this moment is where we have the problem, since, even if we do "Delete the progress", "Reset the progress" or remove it from the course and re-point it, if you access lesson 1/4 and do Complete Lesson You no longer have to wait the two weeks and the class is visible, but we don't want it to be visible to the student.

His partner reproduced the error and for that reason the incident was opened

Hi Rafael,

Thanks for getting back to us and sending the details of the workflow you have been following to remove the learner's access to the lessons.

I was able to check and reproduce the issue on my test site. I have submitted a report about this to our developers.

We will get back to you with their reply soon.

Best,

Gaurav,

Happiness Engineer: Automattic, Inc. https://automattic.com/

Crowdsignal https://crowdsignal.com/ | Jetpack https://jetpack.com/ | Sensei https://senseilms.com/ | WordPress.com https://wordpress.com/ | WP Job Manager https://wpjobmanager.com/

We'll await for further news

Thanks and regards

El lun, 24 may 2021 a las 17:00, Renatho De Carli Rosa (< @.***>) escribió:

I was exploring it to reproduce the issue, but I'm not able to. What I did:

  1. Create a lesson with a drip schedule "A specific interval after the course start date" / "1" / "Day(s)".
  2. Enroll the learner in the course, and make sure they still don't have access.
  3. Go to the Learner Management, and "Manage learners" for the enrolled course.
  4. Edit the enrollment date to be sooner (a date that they would already gain the drip access).
  5. Make sure now the learner has access.
  6. Update the course enrollment date again to later (a date that they wouldn't have the drip access).
  7. Test with the learner and confirm they don't have access again.

An exception is when the learner completed the lesson when they had access. In this case, I went to the lesson in Learner Management and clicked on "Reset Progress" (besides the previously mentioned steps).

Everything worked as expected for me. Is there something I'm missing here?

They have a course set up with lessons access given after 7 days of completing the previous lesson

Maybe is there some confusion based on this? Because AFAIK we can't set up it based on the previous lesson completion, but we can make it based on the course starting date. Reading the ticket, I think the user set up based on the course starting date.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/woocommerce/sensei-content-drip/issues/222#issuecomment-847100753, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR2RZNZOMTOAZQ7YMYJJGZDTPJSZ5ANCNFSM43OYCGPA .

gaurav1984 commented 3 years ago

Hi @renatho I followed your steps on my test site to check for the issue and in doing so landed on the correct path to resolving this issue.

Here is a Screencast of what I did https://d.pr/v/1DOBTQ

dericleeyy commented 3 years ago

I think this might be a bug.

From our docs:

If a learner has already been given access to a lesson, when you select that learner and that lesson, the Give Access button will change to Remove Access.

When a learner has access already, the button does not change to become Remove Access.

renatho commented 3 years ago

I think this might be a bug.

From our docs:

If a learner has already been given access to a lesson, when you select that learner and that lesson, the Give Access button will change to Remove Access.

When a learner has access already, the button does not change to become Remove Access.

Thank you for reporting it @dericleeyy ! I created a PR with the fix here: https://github.com/woocommerce/sensei-content-drip/pull/227

renatho commented 3 years ago

Closing this issue since it doesn't seem valid. See https://github.com/woocommerce/sensei-content-drip/issues/222#issuecomment-850336263 and https://github.com/woocommerce/sensei-content-drip/issues/222#issuecomment-847100753.