woocommerce / storefront-homepage-contact-section

5 stars 4 forks source link

📦 NEW: Add build tools (#11) #16

Open nielslange opened 4 years ago

nielslange commented 4 years ago

Fixes #11

Add build tools to generate CSS and translations files.

Screenshots

n/a

How to test the changes in this Pull Request:

  1. Check out this PR
  2. Run npm i to install all dependencies → Dependencies should be installed
  3. Run npm run build to build the extension → The file storefront-homepage-contact-section.zip should be created in root
  4. Run npm run build:dev to render JS and SCSS files → The files assets/css/style.css, assets/css/style.css.map & assets/css/style.min.css will be rendered
  5. Run npm run start to watch SCSS changes → If src/css/style.scss will be changes, the files assets/css/style.css, assets/css/style.css.map & assets/css/style.min.css will be rendered
  6. Run npm run watch to watch SCSS changes → If src/css/style.scss will be changes, the files assets/css/style.css, assets/css/style.css.map & assets/css/style.min.css will be rendered
  7. Run npm run js to render JS files → As this repo does not contain JS files, this will not deliver a result
  8. Run npm run css to render SCSS files → The files assets/css/style.css, assets/css/style.css.map & assets/css/style.min.css will be rendered
  9. Run npm run makepot to render the POT file → The file languages/storefront-homepage-contact-section.pot will be rendered

Changelog

Dev - Add build tools to generate CSS and translations files. #11

Tests

n/a

jconroy commented 4 years ago

LGTM! The only extra thing I've done with others is add a readme.md

Update - ignore me - you have an issue for adding a readme https://github.com/woocommerce/storefront-homepage-contact-section/issues/15

nielslange commented 4 years ago

LGTM! The only extra thing I've done with others is add a readme.md

Update - ignore me - you have an issue for adding a readme #15

I'll make a note to #15 to add the NPM commands to the README.md. I also added README.md to all SF child themes that haven't had one yet and will add the NPM commends to these files as well.

jconroy commented 3 years ago

Note to self bump tested up to tag