Customizer left sidebar layout not working on My Account page

[tobinfekkes]

Describe the bug

I'm not sure what changed recently with either WooCommerce or Storefront, but the My Account layout does not respect the Layout options selected in the Customizer. I have tested this on four different sites, all with only Storefront 2.5.3 and a couple of the more recent WooCommerce versions, and get varying results. Either the My Account Nav links are stuck on the right sidebar no matter which Layout option is chosen, or the sidebar shows up opposite to what is selected in Customizer. The conflict is on the

element: <nav class="woocommerce-MyAccount-navigation"> and the CSS culprit is in the Storefront woocommerce.css at lines 1999, somewhat overriding 1979 with the fullwidth template. I've tried child themes with different templates, as well as no child themes with just stock WC/Storefront.

Isolating the problem (mark completed items with an [x]):

• [ x ] I have deactivated other plugins and themes and confirmed this bug occurs when only WooCommerce + Storefront theme are active.
• [ x ] I can reproduce this bug consistently using the steps below.

To Reproduce

Steps to reproduce the behavior:

1. Go to 'My Account' Page

Screenshots

If applicable, add screenshots to help explain your problem.

Expected behavior

I expect the Nav Sidebar Layout to respect the layout selected in the Customizer settings. When I select sidebar left / content right, I get the opposite.

Browser Environment

Please provide as much detail as possible about your testing environment.

• Platform: e.g. Windows 10
• Browser(s): Both Chrome and Brave (not that they differ much...), and Edge

WordPress Environment

Please provide relevant details of your WordPress setup and server environment.

Below is the most recent, clean install I'm using, but I've tested on completely different servers, setups, apache/nginx, child themes, etc.

``` ` ### WordPress Environment ### WordPress address (URL): https://www.lunatechnw.com Site address (URL): https://www.lunatechnw.com WC Version: 3.9.1 REST API Version: ✔ 1.0.7 Log Directory Writable: ✔ WP Version: 5.3.2 WP Multisite: – WP Memory Limit: 256 MB WP Debug Mode: – WP Cron: ✔ Language: en_US External object cache: – ### Server Environment ### Server Info: nginx/1.16.1 PHP Version: 7.4.0 PHP Post Max Size: 512 MB PHP Time Limit: 600 PHP Max Input Vars: 5000 cURL Version: 7.58.0 OpenSSL/1.1.1d SUHOSIN Installed: – MySQL Version: 8.0.17-8 Max Upload Size: 512 MB Default Timezone is UTC: ✔ fsockopen/cURL: ✔ SoapClient: ✔ DOMDocument: ✔ GZip: ✔ Multibyte String: ✔ Remote Post: ✔ Remote Get: ✔ ### Database ### WC Database Version: 3.9.1 WC Database Prefix: wp_ Total Database Size: 6.19MB Database Data Size: 4.82MB Database Index Size: 1.37MB wp_woocommerce_sessions: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_api_keys: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_attribute_taxonomies: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_downloadable_product_permissions: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_woocommerce_order_items: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_order_itemmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_tax_rates: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_woocommerce_tax_rate_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_shipping_zones: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_woocommerce_shipping_zone_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_shipping_zone_methods: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_woocommerce_payment_tokens: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_payment_tokenmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_log: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_commentmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_comments: Data: 0.06MB + Index: 0.09MB + Engine InnoDB wp_imagify_files: Data: 0.02MB + Index: 0.08MB + Engine InnoDB wp_imagify_folders: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_links: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_ms_snippets: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_options: Data: 2.50MB + Index: 0.03MB + Engine InnoDB wp_postmeta: Data: 1.36MB + Index: 0.06MB + Engine InnoDB wp_posts: Data: 0.14MB + Index: 0.09MB + Engine InnoDB wp_snippets: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_term_relationships: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_term_taxonomy: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_termmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_terms: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_usermeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_users: Data: 0.02MB + Index: 0.05MB + Engine InnoDB wp_wc_admin_note_actions: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_admin_notes: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_wc_category_lookup: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_wc_customer_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_download_log: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_order_coupon_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_order_product_lookup: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_wc_order_stats: Data: 0.02MB + Index: 0.05MB + Engine InnoDB wp_wc_order_tax_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_product_meta_lookup: Data: 0.02MB + Index: 0.09MB + Engine InnoDB wp_wc_tax_rate_classes: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_webhooks: Data: 0.02MB + Index: 0.02MB + Engine InnoDB ### Post Type Counts ### attachment: 48 ct_template: 6 customize_changeset: 11 nav_menu_item: 1 page: 11 post: 2 revision: 6 scheduled-action: 183 ### Security ### Secure connection (HTTPS): ✔ Hide errors from visitors: ✔ ### Active Plugins (1) ### WooCommerce: by Automattic – 3.9.1 ### Inactive Plugins (13) ### Advanced Custom Fields PRO: by Elliot Condon – 5.7.13 Auto Image Attributes From Filename With Bulk Updater: by Arun Basil Lal – 1.6 CoBlocks: by GoDaddy – 1.20.1 Display All Image Sizes: by Press Up – 1.1.6 GridPane Redis Object Cache: by Till Krüss | Forked by GridPane – 1.5.5 Imagify: by WP Media – 1.9.8.1 ManageWP - Worker: by GoDaddy – 4.9.2 Nginx Helper: by rtCamp – 2.2.1 Ultimate Addons for Gutenberg: by Brainstorm Force – 1.14.6 WooCommerce Admin: by WooCommerce – 0.25.1 WooCommerce Beta Tester: by WooCommerce – 2.0.1 – Not tested with the active version of WooCommerce WooCommerce Blocks: by Automattic – 2.5.11 – Not tested with the active version of WooCommerce WP Rocket: by WP Media – 3.4.3 ### Must Use Plugins (2) ### GridPane Mailer: by Chad Butler Jeff Cleverley – 1.0.0 WP CLI Login Command Server: by Evan Mattson – 1.2 ### Settings ### API Enabled: – Force SSL: – Currency: USD ($) Currency Position: left Thousand Separator: , Decimal Separator: . Number of Decimals: 2 Taxonomies: Product Types: external (external) grouped (grouped) simple (simple) variable (variable) Taxonomies: Product Visibility: exclude-from-catalog (exclude-from-catalog) exclude-from-search (exclude-from-search) featured (featured) outofstock (outofstock) rated-1 (rated-1) rated-2 (rated-2) rated-3 (rated-3) rated-4 (rated-4) rated-5 (rated-5) Connected to WooCommerce.com: – ### WC Pages ### Shop base: #30 - /shop/ Cart: #31 - /cart/ Checkout: #32 - /checkout/ My account: #33 - /my-account/ Terms and conditions: ❌ Page not set ### Theme ### Name: Storefront Version: 2.5.3 Author URL: https://woocommerce.com/ Child Theme: ❌ – If you are modifying WooCommerce on a parent theme that you did not build personally we recommend using a child theme. See: How to create a child theme WooCommerce Support: ✔ ### Templates ### Overrides: – ### Action Scheduler ### Complete: 182 Oldest: 2020-02-01 15:20:05 -0800 Newest: 2020-02-10 18:36:14 -0800 Pending: 0 Oldest: – Newest: – Canceled: 1 Oldest: 2020-02-10 19:36:14 -0800 Newest: 2020-02-10 19:36:14 -0800 In-progress: 0 Oldest: – Newest: – Failed: 0 Oldest: – Newest: – ` ```

[haszari]

Thanks for reporting this @tobinfekkes.

I've tested with 2.5.3 and I can reproduce the following behaviour. If I set the Customizer General Layout option so the sidebar is on the left, the My Account page always shows the sidebar on the right. I'd guess that this is not a new issue, possibly this is by design (the My Account page has a different sidebar).

Do you remember when you first saw this?

How does this issue impact your site?

[haszari]

I also tested with Storefront 2.5.0. The behaviour was the same - My Account sidebar is always displayed on the right. So that suggests to me that this behaviour might be as intended - the bug has not been introduced recently.

[GlennMartin1]

Related to https://github.com/woocommerce/storefront/issues/1136?

[haszari]

Thanks @GlennMartin1 for tracking down the context here. Based on #1136 and #712 this is behaving as intended.