search

woocommerce / storefront

Official theme for WooCommerce
https://wordpress.org/themes/storefront/
961 stars 472 forks source link

PHP and JS automated tests fails when pushing code #2004

Closed danieldudzic closed 1 year ago

danieldudzic commented 2 years ago

When doing the 4.1.1 release, I have noticed a bunch of unrelated errors before merging the PR.

  1. Multiple instances of the same PHP error in inc/class-storefront.php: A hook was found, but was not accompanied by a docblock comment on the line above to clarify the meaning of the hook.

  2. JS Lint fail: ESLint issues detected.

It would be good to tidy this up, to make sure that new bugs won't fall through the cracks.