woocommerce / storefront

Official theme for WooCommerce
https://wordpress.org/themes/storefront/
974 stars 470 forks source link

Editor styles override text color settings for Featured Product and Featured Category blocks #2036

Closed danielwrobert closed 2 years ago

danielwrobert commented 2 years ago

Describe the bug

Clearly describe the issue. Please be as descriptive as possible; issues lacking detail, or for any other reason than to report a bug, may be closed without action.

The CSS ruleset defined in the Customizer styles overrides the default text color in the editor for the Featured Product and Featured Category blocks. Due to the darker background overlay for those two blocks, there is very poor color contrast with the color defined in the aforementioned Customizer ruleset.

To Reproduce

Steps to reproduce the behavior:

  1. With the Storefront theme active, add a Featured Product or Featured Category block into a post or page.
  2. Confirm the text is not white, as expected by the default settings of the block. Also confirm the poor color contrast.

Screen Shot 2022-09-06 at 10 14 27 PM

Expected behavior

There should be enough color contrast with the text and background. The theme styles should also not override the block styles, unless intended for good reason.

Additional context

This issue was originally reported on the WooCommerce Blocks repo and solved in this PR. However, that fix eventually prevented the Global Styles from taking effect for the text on these two blocks.

This PR reverts the change from within the Woo Blocks repo, leaving it to the Storefront theme to address (considering that is where the issue originates).