search

woocommerce / storefront

Official theme for WooCommerce
https://wordpress.org/themes/storefront/
959 stars 472 forks source link

Storefront 4.4.0: Mobile Menu not working #2107

Closed cuemarie closed 11 months ago

cuemarie commented 11 months ago

Originally reported here: https://github.com/Automattic/themes/issues/7236

Describe the bug

The mobile menu on Storefront stopped working on the latest version, 4.4.0.

Isolating the problem (mark completed items with an [x]):

To Reproduce

Steps to reproduce the behavior:

  1. Activate theme Storefront version 4.4.0
  2. Appearance > Customize: Create a new menu and select the Handheld Menu location.
  3. Add some menu items and save.
  4. View your site on a mobile device, or using browser responsiveness tools
  5. Try to open the overlay menu

Screenshots

If applicable, add screenshots to help explain your problem.

Self-hosted site, No plugins active

https://github.com/woocommerce/storefront/assets/27249804/20db9a00-1e7f-4452-aa93-187c192e963e

WordPress.com site, showing behavior before and after update to 4.4.0

https://github.com/woocommerce/storefront/assets/27249804/9e026b78-b412-4956-8284-e0a5806804c4

Expected behavior

The mobile menu should open the overlay and allow me to navigate the site.

Browser Environment

Please provide as much detail as possible about your testing environment.

WordPress Environment

WordPress 6.2.2

Bug is replicable with and without WooCommerce plugin active on the site. Below is the system status from my WordPress.com Test site:

``` ` ### WordPress Environment ### WordPress address (URL): https://wootestmq.wpcomstaging.com Site address (URL): https://wootestmq.wpcomstaging.com WC Version: 7.8.2 REST API Version: ✔ 7.8.2 WC Blocks Version: ✔ 10.6.0 Action Scheduler Version: ✔ 3.5.4 Log Directory Writable: ✔ WP Version: 6.2.2 WP Multisite: – WP Memory Limit: 512 MB WP Debug Mode: ✔ WP Cron: ✔ Language: en_US External object cache: ✔ ### Server Environment ### Server Info: nginx PHP Version: 8.0.29 PHP Post Max Size: 2 GB PHP Time Limit: 1200 PHP Max Input Vars: 6144 cURL Version: 8.0.1 OpenSSL/1.1.1n SUHOSIN Installed: – MySQL Version: 10.4.26-MariaDB-log Max Upload Size: 2 GB Default Timezone is UTC: ✔ fsockopen/cURL: ✔ SoapClient: ✔ DOMDocument: ✔ GZip: ✔ Multibyte String: ✔ Remote Post: ✔ Remote Get: ✔ ### Database ### WC Database Version: 7.8.2 WC Database Prefix: wp_ Total Database Size: 17.23MB Database Data Size: 12.57MB Database Index Size: 4.66MB wp_woocommerce_sessions: Data: 0.11MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_api_keys: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_attribute_taxonomies: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_downloadable_product_permissions: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_woocommerce_order_items: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_order_itemmeta: Data: 0.06MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_tax_rates: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_woocommerce_tax_rate_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_shipping_zones: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_woocommerce_shipping_zone_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_shipping_zone_methods: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_woocommerce_payment_tokens: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_payment_tokenmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_log: Data: 0.02MB + Index: 0.02MB + Engine InnoDB backup_wp_options: Data: 1.52MB + Index: 0.06MB + Engine InnoDB vp_backup_wp_actionscheduler_actions: Data: 0.06MB + Index: 0.13MB + Engine InnoDB vp_backup_wp_actionscheduler_claims: Data: 0.02MB + Index: 0.02MB + Engine InnoDB vp_backup_wp_actionscheduler_groups: Data: 0.02MB + Index: 0.02MB + Engine InnoDB vp_backup_wp_actionscheduler_logs: Data: 0.05MB + Index: 0.03MB + Engine InnoDB vp_backup_wp_commentmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB vp_backup_wp_comments: Data: 0.02MB + Index: 0.09MB + Engine InnoDB vp_backup_wp_links: Data: 0.02MB + Index: 0.02MB + Engine InnoDB vp_backup_wp_options: Data: 1.11MB + Index: 0.06MB + Engine InnoDB vp_backup_wp_postmeta: Data: 1.52MB + Index: 0.16MB + Engine InnoDB vp_backup_wp_posts: Data: 0.19MB + Index: 0.06MB + Engine InnoDB vp_backup_wp_snippets: Data: 0.02MB + Index: 0.03MB + Engine InnoDB vp_backup_wp_termmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB vp_backup_wp_terms: Data: 0.02MB + Index: 0.03MB + Engine InnoDB vp_backup_wp_term_relationships: Data: 0.02MB + Index: 0.02MB + Engine InnoDB vp_backup_wp_term_taxonomy: Data: 0.02MB + Index: 0.03MB + Engine InnoDB vp_backup_wp_usermeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB vp_backup_wp_users: Data: 0.02MB + Index: 0.05MB + Engine InnoDB vp_backup_wp_wc_admin_notes: Data: 0.09MB + Index: 0.00MB + Engine InnoDB vp_backup_wp_wc_admin_note_actions: Data: 0.08MB + Index: 0.02MB + Engine InnoDB vp_backup_wp_wc_bookings_availability: Data: 0.02MB + Index: 0.02MB + Engine InnoDB vp_backup_wp_wc_bookings_availabilitymeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB vp_backup_wp_wc_booking_relationships: Data: 0.02MB + Index: 0.03MB + Engine InnoDB vp_backup_wp_wc_category_lookup: Data: 0.02MB + Index: 0.00MB + Engine InnoDB vp_backup_wp_wc_customer_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB vp_backup_wp_wc_download_log: Data: 0.02MB + Index: 0.03MB + Engine InnoDB vp_backup_wp_wc_order_bundle_lookup: Data: 0.02MB + Index: 0.09MB + Engine InnoDB vp_backup_wp_wc_order_coupon_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB vp_backup_wp_wc_order_product_lookup: Data: 0.02MB + Index: 0.06MB + Engine InnoDB vp_backup_wp_wc_order_stats: Data: 0.02MB + Index: 0.05MB + Engine InnoDB vp_backup_wp_wc_order_tax_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB vp_backup_wp_wc_product_attributes_lookup: Data: 0.02MB + Index: 0.02MB + Engine InnoDB vp_backup_wp_wc_product_download_directories: Data: 0.02MB + Index: 0.02MB + Engine InnoDB vp_backup_wp_wc_product_meta_lookup: Data: 0.02MB + Index: 0.09MB + Engine InnoDB vp_backup_wp_wc_rate_limits: Data: 0.02MB + Index: 0.02MB + Engine InnoDB vp_backup_wp_wc_reserved_stock: Data: 0.02MB + Index: 0.00MB + Engine InnoDB vp_backup_wp_wc_tax_rate_classes: Data: 0.02MB + Index: 0.02MB + Engine InnoDB vp_backup_wp_wc_webhooks: Data: 0.02MB + Index: 0.02MB + Engine InnoDB vp_backup_wp_woocommerce_api_keys: Data: 0.02MB + Index: 0.03MB + Engine InnoDB vp_backup_wp_woocommerce_attribute_taxonomies: Data: 0.02MB + Index: 0.02MB + Engine InnoDB vp_backup_wp_woocommerce_bis_activity: Data: 0.02MB + Index: 0.05MB + Engine InnoDB vp_backup_wp_woocommerce_bis_notifications: Data: 0.02MB + Index: 0.09MB + Engine InnoDB vp_backup_wp_woocommerce_bis_notificationsmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB vp_backup_wp_woocommerce_bundled_itemmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB vp_backup_wp_woocommerce_bundled_items: Data: 0.02MB + Index: 0.03MB + Engine InnoDB vp_backup_wp_woocommerce_downloadable_product_permissions: Data: 0.02MB + Index: 0.06MB + Engine InnoDB vp_backup_wp_woocommerce_log: Data: 0.02MB + Index: 0.02MB + Engine InnoDB vp_backup_wp_woocommerce_order_itemmeta: Data: 0.06MB + Index: 0.03MB + Engine InnoDB vp_backup_wp_woocommerce_order_items: Data: 0.02MB + Index: 0.02MB + Engine InnoDB vp_backup_wp_woocommerce_payment_tokenmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB vp_backup_wp_woocommerce_payment_tokens: Data: 0.02MB + Index: 0.02MB + Engine InnoDB vp_backup_wp_woocommerce_sessions: Data: 0.08MB + Index: 0.02MB + Engine InnoDB vp_backup_wp_woocommerce_shipping_zones: Data: 0.02MB + Index: 0.00MB + Engine InnoDB vp_backup_wp_woocommerce_shipping_zone_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB vp_backup_wp_woocommerce_shipping_zone_methods: Data: 0.02MB + Index: 0.00MB + Engine InnoDB vp_backup_wp_woocommerce_tax_rates: Data: 0.02MB + Index: 0.06MB + Engine InnoDB vp_backup_wp_woocommerce_tax_rate_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_actionscheduler_actions: Data: 0.05MB + Index: 0.13MB + Engine InnoDB wp_actionscheduler_claims: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_actionscheduler_groups: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_actionscheduler_logs: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_commentmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_comments: Data: 0.02MB + Index: 0.09MB + Engine InnoDB wp_links: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_options: Data: 2.19MB + Index: 0.08MB + Engine InnoDB wp_postmeta: Data: 2.52MB + Index: 0.17MB + Engine InnoDB wp_posts: Data: 0.27MB + Index: 0.06MB + Engine InnoDB wp_snippets: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_termmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_terms: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_term_relationships: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_term_taxonomy: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_usermeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_users: Data: 0.02MB + Index: 0.05MB + Engine InnoDB wp_wc_admin_notes: Data: 0.09MB + Index: 0.00MB + Engine InnoDB wp_wc_admin_note_actions: Data: 0.08MB + Index: 0.02MB + Engine InnoDB wp_wc_bookings_availability: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_bookings_availabilitymeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_booking_relationships: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_category_lookup: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_wc_customer_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_download_log: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_order_bundle_lookup: Data: 0.02MB + Index: 0.09MB + Engine InnoDB wp_wc_order_coupon_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_order_product_lookup: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_wc_order_stats: Data: 0.02MB + Index: 0.05MB + Engine InnoDB wp_wc_order_tax_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_product_attributes_lookup: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_product_download_directories: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_product_meta_lookup: Data: 0.02MB + Index: 0.09MB + Engine InnoDB wp_wc_rate_limits: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_reserved_stock: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_wc_tax_rate_classes: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_webhooks: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_bis_activity: Data: 0.02MB + Index: 0.05MB + Engine InnoDB wp_woocommerce_bis_notifications: Data: 0.02MB + Index: 0.09MB + Engine InnoDB wp_woocommerce_bis_notificationsmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_bundled_itemmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_bundled_items: Data: 0.02MB + Index: 0.03MB + Engine InnoDB __wp_commentmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB __wp_comments: Data: 0.02MB + Index: 0.08MB + Engine InnoDB __wp_links: Data: 0.02MB + Index: 0.02MB + Engine InnoDB __wp_options: Data: 0.11MB + Index: 0.03MB + Engine InnoDB __wp_postmeta: Data: 0.20MB + Index: 0.06MB + Engine InnoDB __wp_posts: Data: 0.05MB + Index: 0.06MB + Engine InnoDB __wp_termmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB __wp_terms: Data: 0.02MB + Index: 0.03MB + Engine InnoDB __wp_term_relationships: Data: 0.02MB + Index: 0.02MB + Engine InnoDB __wp_term_taxonomy: Data: 0.02MB + Index: 0.03MB + Engine InnoDB __wp_usermeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB __wp_users: Data: 0.02MB + Index: 0.05MB + Engine InnoDB ### Post Type Counts ### attachment: 21 customize_changeset: 33 custom_css: 2 jetpack_migration: 2 nav_menu_item: 12 page: 13 post: 5 product: 6 product_variation: 18 revision: 52 shop_coupon: 1 shop_order: 16 wp_global_styles: 11 wp_navigation: 2 wp_template: 2 wp_template_part: 1 ### Security ### Secure connection (HTTPS): ✔ Hide errors from visitors: ✔ ### Active Plugins (13) ### Akismet Anti-Spam: Spam Protection: by Automattic - Anti Spam Team – 5.2 CoBlocks: by GoDaddy – 3.0.4 Crowdsignal Forms: by Automattic – 1.7.0 WordPress.com Editing Toolkit: by Automattic – 3.71520 Gutenberg: by Gutenberg Team – 16.2.0 Jetpack: by Automattic – 12.4-a.4 Layout Grid: by Automattic – 1.8.4 Page Optimize: by Automattic – 0.5.3 Crowdsignal Polls & Ratings: by Automattic Inc. – 3.0.10 WooCommerce Blocks: by Automattic – 10.6.0 WooCommerce Back In Stock Notifications: by WooCommerce – 1.6.3 WooCommerce Payments: by Automattic – 6.1.1 WooCommerce: by Automattic – 7.8.2 ### Inactive Plugins (11) ### Classic Editor: by WordPress Contributors – 1.6.3 Kadence Blocks – Gutenberg Blocks for Page Builder Features: by Kadence WP – 3.0.41 myStickymenu: by Premio – 2.6.4 Product Image Zoom for WooCommerce: by wpbean – 1.05.3 Smooth Back To Top Button: by Tanvirul Haque – 1.1.9 WC Disable Zoom / Lightbox features: by Rynaldo Stoltz – 1.1 WooCommerce Beta Tester: by WooCommerce – 2.1.0 WooCommerce Shipping & Tax: by WooCommerce – 2.3.0 Woocommerce Single Product Page Customizer: by Geek Code Lab – 2.4 WooCommerce Stripe Gateway: by WooCommerce – 7.4.1 WP Sticky Menu: by PTHEME – 1.1.0 ### Dropin Plugins (2) ### advanced-cache.php: advanced-cache.php object-cache.php: Memcached ### Must Use Plugins (1) ### WP.com Site Helper: by – ### Settings ### API Enabled: – Force SSL: – Currency: USD ($) Currency Position: left Thousand Separator: , Decimal Separator: . Number of Decimals: 2 Taxonomies: Product Types: bundle (bundle) external (external) grouped (grouped) simple (simple) subscription (subscription) variable (variable) variable subscription (variable-subscription) Taxonomies: Product Visibility: exclude-from-catalog (exclude-from-catalog) exclude-from-search (exclude-from-search) featured (featured) outofstock (outofstock) rated-1 (rated-1) rated-2 (rated-2) rated-3 (rated-3) rated-4 (rated-4) rated-5 (rated-5) Connected to WooCommerce.com: – Enforce Approved Product Download Directories: – HPOS feature screen enabled: – HPOS feature enabled: – Order datastore: WC_Order_Data_Store_CPT HPOS data sync enabled: – ### WC Pages ### Shop base: #8 - /shop/ Cart: #9 - /cart/ Checkout: #10 - /checkout/ My account: #11 - /my-account/ Terms and conditions: #232 - /terms-and-conditions/ ### Theme ### Name: Storefront Version: 4.4.0 Author URL: https://woocommerce.com/ Child Theme: ❌ – If you are modifying WooCommerce on a parent theme that you did not build personally we recommend using a child theme. See: How to create a child theme WooCommerce Support: ✔ ### Templates ### Overrides: – ### Subscriptions ### WCS_DEBUG: ✔ No Subscriptions Mode: ✔ Live Subscriptions Live URL: https://wootestmq.wpcomstaging.com Subscriptions-core Library Version: 5.7.2 Subscription Statuses: – WooCommerce Account Connected: ❌ No ### Store Setup ### Country / State: United States (US) — Arizona ### Subscriptions by Payment Gateway ### ### Payment Gateway Support ### WooCommerce Payments: products refunds multiple_subscriptions subscription_cancellation subscription_payment_method_change_admin subscription_payment_method_change_customer subscription_payment_method_change subscription_reactivation subscription_suspension subscriptions gateway_scheduled_payments tokenization add_payment_method ### Back In Stock ### Database Version: 1.6.3 Loopback Test: ✔ ### Admin ### Enabled Features: activity-panels analytics product-block-editor coupons customer-effort-score-tracks import-products-task experimental-fashion-sample-products shipping-smart-defaults shipping-setting-tour homescreen marketing mobile-app-banner navigation onboarding onboarding-tasks remote-inbox-notifications remote-free-extensions payment-gateway-suggestions shipping-label-banner subscriptions store-alerts transient-notices woo-mobile-welcome wc-pay-promotion wc-pay-welcome-page Disabled Features: core-profiler minified-js new-product-management-experience product-variation-management settings async-product-editor-category-field Daily Cron: ✔ Next scheduled: 2023-07-13 16:14:19 -07:00 Options: ✔ Notes: 157 Onboarding: completed ### WooCommerce Payments ### Version: 6.1.1 Connected to WPCOM: Yes Blog ID: 198757002 Account ID: acct_1K1hN02HhjzWWnfl ### Action Scheduler ### Complete: 47 Oldest: 2023-06-12 10:19:09 -0700 Newest: 2023-07-12 11:12:11 -0700 Failed: 13 Oldest: 2023-02-15 13:17:57 -0700 Newest: 2023-06-15 23:24:57 -0700 Pending: 2 Oldest: 2023-07-13 11:11:04 -0700 Newest: 2023-07-15 23:24:57 -0700 ### Status report information ### Generated at: 2023-07-12 18:00:10 -07:00 ` ```
danielwrobert commented 11 months ago

@cuemarie thank you for reporting this!

The issue was that there were some missing assets in the release build for 4.4.0. I just pushed a patch release for version 4.4.1 that fixes this.

Before After
CleanShot 2023-07-12 at 22 26 14@2x CleanShot 2023-07-12 at 22 21 32@2x

I'm going to go ahead and close this issue out now. Thanks again!