search

woocommerce / storefront

Official theme for WooCommerce
https://wordpress.org/themes/storefront/
959 stars 472 forks source link

A deprecated notice appears on the admin and front end with WP 6.3 #2119

Closed apeksha10 closed 10 months ago

apeksha10 commented 10 months ago

Describe the bug

A deprecated notice appears on the admin and front end with WP 6.3

To Reproduce

Steps to reproduce the behavior:

  1. Install and activate the WP 6.3
  2. Some deprecated notice appears on the admin and frontend

Screenshot : https://app.screencast.com/beGQ37Q4btAxI

Error :

[11-Aug-2023 12:20:49 UTC] PHP Deprecated: Function WP_Scripts::print_inline_script is deprecated since version 6.3.0! Use WP_Scripts::get_inline_script_data() or WP_Scripts::get_inline_script_tag() instead. in C:\Users\User\Local Sites\beta-tester\app\public\wp-includes\functions.php on line 5453 [11-Aug-2023 12:20:49 UTC] PHP Stack trace: [11-Aug-2023 12:20:49 UTC] PHP 1. {main}() C:\Users\User\Local Sites\beta-tester\app\public\index.php:0 [11-Aug-2023 12:20:49 UTC] PHP 2. require() C:\Users\User\Local Sites\beta-tester\app\public\index.php:17 [11-Aug-2023 12:20:49 UTC] PHP 3. require_once() C:\Users\User\Local Sites\beta-tester\app\public\wp-blog-header.php:19 [11-Aug-2023 12:20:49 UTC] PHP 4. include() C:\Users\User\Local Sites\beta-tester\app\public\wp-includes\template-loader.php:106 [11-Aug-2023 12:20:49 UTC] PHP 5. get_footer($name = 'shop', $args = uninitialized) C:\Users\User\Local Sites\beta-tester\app\public\wp-content\plugins\woocommerce\templates\archive-product.php:105 [11-Aug-2023 12:20:49 UTC] PHP 6. locate_template($template_names = [0 => 'footer-shop.php', 1 => 'footer.php'], $load = TRUE, $load_once = TRUE, $args = []) C:\Users\User\Local Sites\beta-tester\app\public\wp-includes\general-template.php:92 [11-Aug-2023 12:20:49 UTC] PHP 7. load_template($_template_file = 'C:\Users\User\Local Sites\beta-tester\app\public/wp-content/themes/storefront/footer.php', $load_once = TRUE, $args = []) C:\Users\User\Local Sites\beta-tester\app\public\wp-includes\template.php:720 [11-Aug-2023 12:20:49 UTC] PHP 8. require_once() C:\Users\User\Local Sites\beta-tester\app\public\wp-includes\template.php:785 [11-Aug-2023 12:20:49 UTC] PHP 9. wp_footer() C:\Users\User\Local Sites\beta-tester\app\public\wp-content\themes\storefront\footer.php:37 [11-Aug-2023 12:20:49 UTC] PHP 10. do_action($hook_name = 'wp_footer') C:\Users\User\Local Sites\beta-tester\app\public\wp-includes\general-template.php:3069 [11-Aug-2023 12:20:49 UTC] PHP 11. WP_Hook->do_action($args = [0 => '']) C:\Users\User\Local Sites\beta-tester\app\public\wp-includes\plugin.php:517 [11-Aug-2023 12:20:49 UTC] PHP 12. WP_Hook->apply_filters($value = '', $args = [0 => '']) C:\Users\User\Local Sites\beta-tester\app\public\wp-includes\class-wp-hook.php:334 [11-Aug-2023 12:20:49 UTC] PHP 13. wp_print_footer_scripts('') C:\Users\User\Local Sites\beta-tester\app\public\wp-includes\class-wp-hook.php:310 [11-Aug-2023 12:20:49 UTC] PHP 14. do_action($hook_name = 'wp_print_footer_scripts') C:\Users\User\Local Sites\beta-tester\app\public\wp-includes\script-loader.php:2208 [11-Aug-2023 12:20:49 UTC] PHP 15. WP_Hook->do_action($args = [0 => '']) C:\Users\User\Local Sites\beta-tester\app\public\wp-includes\plugin.php:517 [11-Aug-2023 12:20:49 UTC] PHP 16. WP_Hook->apply_filters($value = '', $args = [0 => '']) C:\Users\User\Local Sites\beta-tester\app\public\wp-includes\class-wp-hook.php:334 [11-Aug-2023 12:20:49 UTC] PHP 17. Automattic\WooCommerce\Blocks\BlockTypes\MiniCart->print_lazy_load_scripts('') C:\Users\User\Local Sites\beta-tester\app\public\wp-includes\class-wp-hook.php:310 [11-Aug-2023 12:20:49 UTC] PHP 18. Automattic\WooCommerce\Blocks\BlockTypes\MiniCart->append_script_and_deps_src($script = class _WP_Dependency { public $handle = 'lodash'; public $src = '/wp-includes/js/dist/vendor/lodash.min.js'; public $deps = []; public $ver = '4.17.19'; public $args = 1; public $extra = ['after' => [...]]; public $textdomain = NULL; public $translations_path = NULL }) C:\Users\User\Local Sites\beta-tester\app\public\wp-content\plugins\woocommerce\packages\woocommerce-blocks\src\BlockTypes\MiniCart.php:245

Expected behavior

No error must be thrown from the storefront theme.

kmanijak commented 10 months ago

Hi, thanks for raising this!

As far as I understand these errors come from Mini Cart block. The problem you raise was already fixed in:

https://github.com/woocommerce/woocommerce-blocks/pull/10165

It's been released in WC Blocks 10.7.1 and included in WooCommerce 8.0. Updating the plugins should help 🙌

I'm going to close this issue but closed issue can be still commented on. So in case you still experience some problem please comment or open new issue, thank you!