woocommerce / storefront

Official theme for WooCommerce
https://wordpress.org/themes/storefront/
972 stars 471 forks source link

Remove max-width on image div for Mix and Match Products extension #2122

Closed helgatheviking closed 1 year ago

helgatheviking commented 1 year ago

Describe the bug

This CSS rule seems unnecessary:

.mnm_image {
    max-width: ms(6);
}

https://github.com/woocommerce/storefront/blob/trunk/assets/css/woocommerce/extensions/mix-and-match.scss#L57-L59

Mix and Match itself is always setting that width to the maximum allowed by the containing DIV (which is the product grid). So in core Mix and Match it's not doing anything, however it is getting in the way of some new features I am working on.

With and without it, this looks the same:

image

And there's no max-width on the image inside the default grid.