woocommerce / storefront

Official theme for WooCommerce
https://wordpress.org/themes/storefront/
972 stars 471 forks source link

Update the "Customize the WooCommerce breadcrumb" Docs page. #870

Closed user-1138 closed 6 years ago

user-1138 commented 6 years ago

Quick FYI - the Customize the WooCommerce breadcrub Docs page, could do with an update. Specifically I have found:

  1. Per issue #609 the Change the breadcrumb separator and the Change all the things snippets both need to have a priority set.
  2. You might also want to mention how the delimiter can now simply be set using the Storefront Customiser via the WordPress Dashboard.
  3. Due to the Breadcrumb wrapper changes in Storefront 2.3.0, the Change all the things snippet also needs to include the div classes storefront-breadcrumb and col-full in the wrap-before and wrap-after array elements, otherwise you cannot set a background-color for the Breadcrumb and it will float left to the edge of the screen (this is how I fixed mine, anyways...). I think the nav itemprop="breadcrumb" can also be removed from wrap-before: 'wrap_before' => '<div class="storefront-breadcrumb"><div class="col-full"><nav class="woocommerce-breadcrumb">', 'wrap_after' => '</nav></div></div>',
  4. Finally, per issue #850 the Remove the breadcrumbs snippet for the Storefront theme needs the hook updated.

Hopefully that'll saves some future angst for others and newbies trying to get on the Woo-Train! :-)

tiagonoronha commented 6 years ago

Thanks! Docs have been updated. :)