search

woocommerce / wc-api-ruby

A Ruby wrapper for the WooCommerce API.
MIT License
69 stars 74 forks source link

migrate from URI.encode to CGI::escape to become ruby 3 ready #59

Open stevereinke opened 1 year ago

stevereinke commented 1 year ago

Hi there.

It would be nicce to use your lib also with ruby 3. Can you check these changes and take this pull request?

Thanks in advance.

Kind regards Steve

sonianand11 commented 1 year ago

If anybody is interested to know why Addressable gem is used to escape the URL, here is the detailed answer https://stackoverflow.com/a/13059657/663660

ricvillagrana commented 8 months ago

Any chance we get this merged?

cc @claudiosanches @choubacha @danielhoey