woocommerce / wc-smooth-generator

Smooth product, customer and order generation for WooCommerce
309 stars 49 forks source link

Fix emails sent out on generation #104

Closed chihsuan closed 2 years ago

chihsuan commented 2 years ago

All Submissions:

Changes proposed in this Pull Request:

Closes #97.

This PR disables the sending emails when generating objects via UI

How to test the changes in this Pull Request:

  1. Use a site with PHP > 8.0 (require minimum php version)
  2. Install WooCommerce and wc-smooth-generator
  3. Go to Tools > WooCommerce Smooth Generator
  4. Generate some order
  5. Go to your email app and observe that no "New order..." emails received.

Please also test CLI

Other information:

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

Fix emails sent out on generation

FOR PR REVIEWER ONLY:

chihsuan commented 2 years ago

It seems the customer email still gets generated when using the UI. This is triggered by generating orders. I tested this in a JN.

Thanks @ilyasfoo I just confirmed this. 🙇‍♂️ Looks like they went to Spam, so I wasn't aware of it. I've fixed it in 41356eedd38a5badc6d002a7a3f60dc594225846.

chihsuan commented 2 years ago

Thanks, now I'm not seeing any emails with the UI. LGTM, but note that I can't test with CLI 🪨

I've tested with CLI again on my JN site. Confirmed no emails were sent to my inbox.