Closed apmwebdev closed 3 years ago
Thanks for the report @apmwebdev - This notice was added pretty late in the cycle leading up to WooCommerce 4.0. While I can see the spirit and purpose behind it... I'm kind of thinking we should remove the notice, and perhaps consider replacing it with a "normal" inbox notification - or since we have some new features coming in wc-admin that might not be active in Woo core, we might want to encourage folks to still have the feature plugin. @pmcpinto any thoughts here?
Another user hc-21693444
'm kind of thinking we should remove the notice, and perhaps consider replacing it with a "normal" inbox notification - or since we have some new features coming in wc-admin that might not be active in Woo core, we might want to encourage folks to still have the feature plugin.
Yep, I think it makes sense to replace this notification with an inbox message as a reminder to uninstall wcadmin
Also seeing this issue.
WooCommerce 4.2.0 (network active). WooCommerce Admin was also network activated, prior to updating to 4.2.0.
Deactivating and then uninstalling the WCA plugin has had no effect on the notice. It still shows the notice, so I am assuming there is some meta data that is still kept in the DB post uninstalling. Based on the plugin code provided that would seem to be the case.
We used the WP-CLI for all processing as well.
Another note for Network Installs.
I just ran through the DB, and I am assuming, as I haven't looked at the WCA plugin code itself, but it appears that the notice is not removed from all tables that are related to each network site on uninstall, but only from the main site DB tables.
I.e. {PREFIX}_wc_admin_notes
had no row for the wc-admin-deactivate-plugin
note, but all subsequent sites tables {PREFIX}_{SITEID}_wc_admin_notes
still had references to it.
I checked the WC_Data_Store
file at https://docs.woocommerce.com/wc-apidocs/source-class-WC_Data_Store.html and I see no reference to get_notes_with_name
, but assuming that the above code does work, I am not sure if it would run through each site.
I've created a PR #4629 that makes new instances of this notification show up in the inbox, where it can use the new 'Dismiss' functionality.
The result looks like this:
Another report on 22010460-hc
3078450-zen
Another one 3188105-zen
We also have this issue ... I would love an update on when this annoying nag will be fixed.
@GldnKey this will be fixed up in the WooCommerce 4.4 release which is due out August 18th. There is also a small fixer plugin available if anyone would like to remove it prior to then: https://gist.github.com/apmwebdev/6a4e4c4032c4d5970050112c03757049
Describe the bug It seems that something in WooCommerce 4.2 is causing an error to pop up on a site dashboard:
I've seen this on two sites now (linked below). Both sites had the stand-alone WooCommerce Admin plugin installed at one point, but no longer do. Clicking the "Deactivate" button in the alert doesn't do anything since there is no longer anything to deactivate, so the alert just stays on the dashboard.
After talking with @timmyc, he recommended I create this issue as a way to track how many sites are experiencing this problem. He also gave me this code as a way to remove the alert on those sites.
Tickets:
To Reproduce I haven't been able to reproduce the behavior. My local test site also had WooCommerce Admin installed at one point and has been upgraded to WooCommerce 4.2, but I am not seeing this issue there.
Expected behavior The alert should not show at all, since WooCommerce Admin was not installed on those sites when the alert popped up.
Isolating the problem (mark completed items with an [x]):