search

woocommerce / woocommerce-admin

(Deprecated) This plugin has been merged to woocommerce/woocommerce
https://woocommerce.github.io/woocommerce-admin/#/
Other
360 stars 145 forks source link

get_automated_tax_supported_countries doesn't include UK #5836

Closed tammullen closed 2 years ago

tammullen commented 3 years ago

Describe the bug get_automated_tax_supported_countries() doesn't include UK as it uses WC_Countries::get_european_union_countries. https://github.com/woocommerce/woocommerce-admin/blob/72b6301a45f5448262f117393d69c5fe16a2bfcf/src/Features/OnboardingTasks.php#L296

However UK is currently supported by TaxJar https://developers.taxjar.com/api/reference/#countries although TaxJar lists it under EU countries so it is unclear if this TaxJar support will continue after Dec 31st 2020 when the Brexit transition period ends (https://ec.europa.eu/taxation_customs/uk_withdrawal_en).

This means a UK store which installed and activated WooCommerce Shipping & Tax during the OBW does not have the tax task completed. Screenshot_2020-12-07_at_20_51_18 Screenshot_2020-12-07_at_20_51_11

To Reproduce

  1. Install a fresh instance of WooCommerce
  2. Enter United Kingdom as Country in Store Details in the setup wizard, choose to install & activate WooCommerce Shipping & Tax when offered.
  3. Observe incomplete Set up tax item in task list.
  4. Install a fresh instance of WooCommerce
  5. Enter Germany as Country in Store Details in the setup wizard, choose to install & activate WooCommerce Shipping & Tax when offered.
  6. Observe completed Set up tax item in task list.
becdetat commented 3 years ago

I've asked TaxJar if the UK will be supported after Dec 31. I've just used their support email address, we probably have a better contact there but at least a ball is rolling :-)

tammullen commented 3 years ago

Looks like TaxJar are continuing to support UK https://blog.taxjar.com/taxjar-will-continue-to-support-uk-and-eu-vat-post-brexit/

joshuatf commented 3 years ago

get_european_union_countries() includes a $type option that will add in GB along with IM and MC.

Seems like the simple and easy solution here is to add GB to the list of allowed countries in https://github.com/woocommerce/woocommerce-admin/blob/6dddef0cbcdd05b6e93347bfc87a830c08133928/src/Features/OnboardingTasks.php#L300