search

woocommerce / woocommerce-admin

(Deprecated) This plugin has been merged to woocommerce/woocommerce
https://woocommerce.github.io/woocommerce-admin/#/
Other
362 stars 146 forks source link

Navigation: Update link colors with Gutenberg 9.7.1 #6052

Closed psealock closed 3 years ago

psealock commented 3 years ago

Gutenberg 9.7.1, which hasn't shipped yet, changes link colors. With the plugin activated, you can only see links on hover.

Screen Shot 2021-01-13 at 9 08 40 AM

To Reproduce

  1. Run a development version of Gutenberg master branch.
  2. Activate Gutenberg plugin
  3. See <a /> links not visible

Deliverables

joshuatf commented 3 years ago

@psealock I wasn't able to repoduce this issue. It seems like the item title is inside a span within the Button component and contains explicit color overrides:

export const ItemUI = styled.div`
    ...
    color: ${ G2.lightGray.ui };
`;

Is there anything else that needs to be done to reproduce this issue or are you seeing this color being overridden in your environment?

joshuatf commented 3 years ago

I can reproduce this now. It only seems to occur on WCA pages with the GB dev plugin active for some reason.

Estimate: 1

timmyc commented 3 years ago

I placed this issue in the 2.0 milestone because the ecommerce plan receives auto-updates of gutenberg by default. And since these users are also opted in to nav by default, this could be a high impact bug there. I did not check the timeline for the release of gutenberg, but depending on when that is, we might even consider doing a css patch in The Bridge just in case.

psealock commented 3 years ago

Here is a PR solving the root issue in Gutenberg https://github.com/WordPress/gutenberg/pull/28619

but depending on when that is, we might even consider doing a css patch in The Bridge just in case.

I haven't done the calculation yet, but it may go the other way where the above fix goes out in the next wp.org release and we don't need to fix it anywhere else.

psealock commented 3 years ago

Version 9.8.3 of Gutenberg is already on wp.org, but I can't reproduce the on my eComm plan. Locally, 9.8.3 breaks which is odd. In any case, a Bridge fix may be in order.

psealock commented 3 years ago

I have duplicated the CSS overrides in wc-admin in https://github.com/woocommerce/woocommerce-admin/pull/6254. I think that with these changes going out in wc-admin 2.0, we won't need to also apply overrides in The Bridge because the changes in this repo will be deployed and published first.