search

woocommerce / woocommerce-admin

(Deprecated) This plugin has been merged to woocommerce/woocommerce
https://woocommerce.github.io/woocommerce-admin/#/
Other
361 stars 144 forks source link

[GlobalStep - WooCommerce 5.0 Beta 2] “Inbox unread indicator” fails to disappear from "WooCommerce->Home" after refreshing the page. #6160

Closed gglobalstep closed 3 years ago

gglobalstep commented 3 years ago

Bug Description:

“Inbox unread indicator” fails to disappear from "WooCommerce->Home" after refreshing the page.

Environment:

macOS High Sierra v10.13.6 Safari: v13.1.2(13609.3.5.1.5) Chrome: v85.0.4183.83

Steps To Reproduce:

  1. Create any test site using Jurassic Ninja.
  2. Install and activate all the required plugins
  3. Complete the Onboarding setup wizard.
  4. Go to Plugins->Add New->Upload plugin.
  5. Install and activate WooCommerce 5.0 plugin.
  6. Go to WooCommerce-> Appearance->Theme and Select StoreFront Theme
  7. Note that an inbox message will be triggered for StoreFront
  8. Goto “Inbox Notification” on WooCommerce->Home Page.
  9. Refresh the page.
  10. Observe that “Inbox unread indicator” fails to disappear from "WooCommerce->Home" after refreshing the page.

Actual Result:

“Inbox unread indicator” fails to disappear from "WooCommerce->Home" after refreshing the page.

Expected Result:

As per test instructions, “Inbox unread indicator” should disappear from "WooCommerce->Home" after refreshing the page.

Video:

https://user-images.githubusercontent.com/41110392/105512298-f2ca8180-5cf6-11eb-8a14-5a52492ea43b.mov

Isolating the problem (mark completed items with an [x]):

``` ### WordPress Environment ### WordPress address (URL): https://public-deer.jurassic.ninja Site address (URL): https://public-deer.jurassic.ninja WC Version: 5.0.0 REST API Version: ✔ 5.0.0 WC Blocks Version: ✔ 4.0.0 Action Scheduler Version: ✔ 3.1.6 WC Admin Version: ✔ 1.9.0-rc.2 Log Directory Writable: ✔ WP Version: 5.6 WP Multisite: – WP Memory Limit: 256 MB WP Debug Mode: ✔ WP Cron: ✔ Language: en_US External object cache: – ### Server Environment ### Server Info: Apache/2.4.46 (Unix) OpenSSL/1.0.2g PHP Version: 7.4.14 PHP Post Max Size: 1 GB PHP Time Limit: 30 PHP Max Input Vars: 5000 cURL Version: 7.47.0 OpenSSL/1.0.2g SUHOSIN Installed: – MySQL Version: 5.7.32-0ubuntu0.16.04.1-log Max Upload Size: 512 MB Default Timezone is UTC: ✔ fsockopen/cURL: ✔ SoapClient: ✔ DOMDocument: ✔ GZip: ✔ Multibyte String: ✔ Remote Post: ✔ Remote Get: ✔ ### Database ### WC Database Version: 5.0.0 WC Database Prefix: wp_ Total Database Size: 3.81MB Database Data Size: 2.38MB Database Index Size: 1.43MB wp_woocommerce_sessions: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_api_keys: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_attribute_taxonomies: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_downloadable_product_permissions: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_woocommerce_order_items: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_order_itemmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_tax_rates: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_woocommerce_tax_rate_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_shipping_zones: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_woocommerce_shipping_zone_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_shipping_zone_methods: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_woocommerce_payment_tokens: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_payment_tokenmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_log: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_actionscheduler_actions: Data: 0.02MB + Index: 0.11MB + Engine InnoDB wp_actionscheduler_claims: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_actionscheduler_groups: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_actionscheduler_logs: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_ce4wp_abandoned_checkout: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_commentmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_comments: Data: 0.02MB + Index: 0.09MB + Engine InnoDB wp_links: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_mailchimp_carts: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_mailchimp_jobs: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_options: Data: 1.48MB + Index: 0.06MB + Engine InnoDB wp_postmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_posts: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_termmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_terms: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_term_relationships: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_term_taxonomy: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_usermeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_users: Data: 0.02MB + Index: 0.05MB + Engine InnoDB wp_wc_admin_notes: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_wc_admin_note_actions: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_category_lookup: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_wc_customer_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_download_log: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_order_coupon_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_order_product_lookup: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_wc_order_stats: Data: 0.02MB + Index: 0.05MB + Engine InnoDB wp_wc_order_tax_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_product_meta_lookup: Data: 0.02MB + Index: 0.09MB + Engine InnoDB wp_wc_reserved_stock: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_wc_tax_rate_classes: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_webhooks: Data: 0.02MB + Index: 0.02MB + Engine InnoDB ### Post Type Counts ### attachment: 1 page: 6 post: 2 ### Security ### Secure connection (HTTPS): ✔ Hide errors from visitors: ❌Error messages should not be shown to visitors. ### Active Plugins (9) ### Companion Plugin: by Osk – 1.18 Creative Mail by Constant Contact: by Constant Contact – 1.3.1 Facebook for WooCommerce: by Facebook – 2.2.0 Jetpack by WordPress.com: by Automattic – 9.3.1 Google Ads & Marketing by Kliken: by Kliken – 1.0.6 Mailchimp for WooCommerce: by Mailchimp – 2.5.0 WooCommerce Beta Tester: by WooCommerce – 2.0.2 WooCommerce Prepare Notes Testing: by WooCommerce – 0.1 WooCommerce: by Automattic – 5.0.0-beta.1 ### Inactive Plugins (2) ### Akismet Anti-Spam: by Automattic – 4.1.7 Hello Dolly: by Matt Mullenweg – 1.7.2 ### Settings ### API Enabled: – Force SSL: – Currency: USD ($) Currency Position: left Thousand Separator: , Decimal Separator: . Number of Decimals: 2 Taxonomies: Product Types: external (external) grouped (grouped) simple (simple) variable (variable) Taxonomies: Product Visibility: exclude-from-catalog (exclude-from-catalog) exclude-from-search (exclude-from-search) featured (featured) outofstock (outofstock) rated-1 (rated-1) rated-2 (rated-2) rated-3 (rated-3) rated-4 (rated-4) rated-5 (rated-5) Connected to WooCommerce.com: – ### WC Pages ### Shop base: #7 - /shop/ Cart: #8 - /cart/ Checkout: #9 - /checkout/ My account: #10 - /my-account/ Terms and conditions: ❌ Page not set ### Theme ### Name: Storefront Version: 3.3.0 Author URL: https://woocommerce.com/ Child Theme: ❌ – If you are modifying WooCommerce on a parent theme that you did not build personally we recommend using a child theme. See: How to create a child theme WooCommerce Support: ✔ ### Templates ### Overrides: – ### Action Scheduler ### Complete: 4 Oldest: 2021-01-22 08:06:53 +0000 Newest: 2021-01-22 11:50:57 +0000 ```
joshuatf commented 3 years ago

I can replicate this issue. The original code that updates the lastRead timestamp (which in turn determines if the unread indicator should appear) does not get updated until the InboxPanel unmounts.

For some context behind this: the original InboxPanel was only accessible via the activity panel, so it could be accessed on all WCA screens and would be unmounted when clicking outside of it to close the panel. Currently it sits on the homescreen, so navigating to another WCA page will trigger an update to that timestamp.

We should probably update the activity_panel_inbox_last_read option when this component mounts instead of unmounts, but this will also require caching the unread time in mount prior to doing this so that the unread indicators don't immediately disappear.

https://github.com/woocommerce/woocommerce-admin/blob/e89cc8a2ef9d193a376c0e5fb8cf6376e7c86b06/client/inbox-panel/index.js#L79-L88

hsingyuc commented 3 years ago

I have a fix for this, will open a PR tomorrow.