search

woocommerce / woocommerce-admin

(Deprecated) This plugin has been merged to woocommerce/woocommerce
https://woocommerce.github.io/woocommerce-admin/#/
Other
361 stars 144 forks source link

Close icon in help menu is cropped #6392

Closed rodelgc closed 3 years ago

rodelgc commented 3 years ago

Describe the bug In mobile portrait view, when you open the Help menu, you would see a cropped "X" icon.

To Reproduce Steps to reproduce the behavior:

  1. Using a mobile device in portrait view, go to 'Home'
  2. Click on the WooCommerce logo at the top-right area of the screen to open the Help menu
  3. Notice that you would see a cropped "X" icon

Expected behavior The "X" icon should be displayed completely

Screenshots

close icon in help menu is cropped

https://user-images.githubusercontent.com/2098816/112167803-20cd2480-8bc7-11eb-8690-7eea680c151a.mov

Smartphone:

ilyasfoo commented 3 years ago

I wasn't able to reproduce this. I've tested Firefox and Chrome on Android and Mac. I've tested on WC 5.0 and WCA 2.1.0.

image

@rodel-calasagsag Can you confirm which version of WCA version you were testing against?

mattsherman commented 3 years ago

I am able to reproduce this with WooCommerce 5.1.0. I've updated the original issue description to include a video of the issue.

mattsherman commented 3 years ago

@elizaan36 @pmcpinto Is there a reason why we put the Help button inside of this WooCommerce icon menu? It seems like there would just be room to display the Help icon right in the header.

elizaan36 commented 3 years ago

hey Matt, this was fixed in #6539

mattsherman commented 3 years ago

@elizaan36 Ha, perfect... glad to see that!

Closing, as this was fixed by #6539