Fix incorrect image upload error message

woocommerce / woocommerce-android

WooCommerce Android app

https://www.woocommerce.com/mobile

GNU General Public License v2.0

262 stars 133 forks source link

Closed 0nko closed 2 weeks ago

0nko commented 2 weeks ago

This PR fixes the wrong private site status message for self-hosted sites, which prevents the app from uploading images.

To test:

Create a self-hosted site with WooCommerce but without installing Jetpack or connecting a WP.com user using JCP
Log in to the app
Start creating a product
Verify the image uploading is available

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1207315305241121

wpmobilebot commented 2 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Flavor	Jalapeno
	Build Type	Debug
	Commit	dcd4c0c0a823705600dc34cb624a82a5d6a1381b
	Direct Download	`woocommerce-prototype-build-pr11493-dcd4c0c.apk`

0nko commented 2 weeks ago

Thanks @hichamboushaba. I've rebased the branch onto release/18.6

hichamboushaba commented 2 weeks ago

Thanks @hichamboushaba. I've rebased the branch onto release/18.6

Thanks @0nko, there is a failing unit test that's preventing the merge.