woocommerce / woocommerce-android

WooCommerce Android app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
262 stars 133 forks source link

[Woo Pos] Compose navigation template #11512

Closed kidinov closed 2 weeks ago

kidinov commented 2 weeks ago

Closes: #11495

Description

The PR:

@samiuelson @backwardstruck @jd-alexander 👋

That's more like a proposal on the approach, so feel free to propose any changes to this

Testing instructions

Images/gif

https://github.com/woocommerce/woocommerce-android/assets/4923871/577fabea-4700-4d84-889e-cdbd0e07735b

wpmobilebot commented 2 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit1a5983d73e381f498e54d5855ba8030e2400a836
Direct Downloadwoocommerce-prototype-build-pr11512-1a5983d.apk
codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 40.80%. Comparing base (7ab8918) to head (f19c30d).

Files Patch % Lines
...ndroid/ui/woopos/root/navigation/WooPosRootHost.kt 0.00% 13 Missing :warning:
...d/ui/woopos/root/navigation/WooPosMainFlowGraph.kt 0.00% 9 Missing :warning:
...oid/ui/woopos/checkout/WooPosCheckoutNavigation.kt 0.00% 4 Missing :warning:
...pos/root/navigation/WooPosNavigationTransitions.kt 0.00% 4 Missing :warning:
...rce/android/ui/woopos/cart/WooPosCartNavigation.kt 0.00% 2 Missing :warning:
...erce/android/ui/woopos/cart/WooPosCartViewModel.kt 0.00% 2 Missing :warning:
...roid/ui/woopos/checkout/WooPosCheckoutViewModel.kt 0.00% 2 Missing :warning:
...ocommerce/android/ui/woopos/root/WooPosActivity.kt 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #11512 +/- ## ============================================ - Coverage 40.82% 40.80% -0.03% Complexity 5180 5180 ============================================ Files 1070 1077 +7 Lines 62327 62358 +31 Branches 8502 8506 +4 ============================================ Hits 25444 25444 - Misses 34595 34626 +31 Partials 2288 2288 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wpmobilebot commented 2 weeks ago

Found 1 violations:

The PR caused the following dependency changes:

expand

```diff ++--- androidx.navigation:navigation-compose -> 2.7.7 (*) +\--- androidx.hilt:hilt-navigation-compose:1.1.0 + +--- androidx.compose.runtime:runtime:1.0.1 -> 1.6.5 (*) + +--- androidx.compose.ui:ui:1.0.1 -> 1.6.5 (*) + +--- androidx.hilt:hilt-navigation:1.1.0 (*) + +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.6.1 -> 2.6.2 (*) + +--- androidx.navigation:navigation-compose:2.5.1 -> 2.7.7 (*) + \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.22 (*) ```

Please review and act accordingly