[Woo POS] Update conditions for showing POS entry point

samiuelson commented 2 weeks ago

Closes: #11498

Description

This PR updates the conditions for showing the POS entry point:

tablet device
USD currency
US store location
Woo Payments plugin enabled and user setup complete
Feature Flag enabled

Testing instructions

Ensure the POS entry point button (in the menu more screen) is visible if the above conditions are met and invisible otherwise.

[x] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

wpmobilebot commented 2 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Flavor	Jalapeno
	Build Type	Debug
	Commit	535d1844d4a08aa53caf9876579e4661d2503801
	Direct Download	`woocommerce-prototype-build-pr11513-535d184.apk`

backwardstruck commented 2 weeks ago

Tested on tablet, phone and split screen:


<img src="https://github.com/woocommerce/woocommerce-android/assets/947561/2c5a9290-5ec5-47d5-a908-7f13a2315210" alt="Screenshot_20240514_144225" height="420">
```html
<img src="https://github.com/woocommerce/woocommerce-android/assets/947561/c179ad32-4ee7-45b5-8866-6a65bb155069" alt="Screenshot_20240514_143646" height="420">

dangermattic commented 2 weeks ago

	1 Warning
:warning:	This PR is assigned to the milestone 18.7. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 40.46%. Comparing base (293506d) to head (cfa9d6b). Report is 9 commits behind head on trunk.

:exclamation: Current head cfa9d6b differs from pull request most recent head 535d184. Consider uploading reports for the commit 535d184 to get more accurate results

Files	Patch %	Lines
...m/woocommerce/android/ui/woopos/IsWooPosEnabled.kt	84.21%	0 Missing and 3 partials :warning:
...woocommerce/android/ui/woopos/IsWooPosFFEnabled.kt	0.00%	2 Missing :warning:
...n/kotlin/com/woocommerce/android/util/UiHelpers.kt	0.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## trunk #11513 +/- ## ============================================ + Coverage 40.45% 40.46% +0.01% - Complexity 5181 5191 +10 ============================================ Files 1082 1083 +1 Lines 62904 62925 +21 Branches 8616 8626 +10 ============================================ + Hits 25447 25463 +16 - Misses 35169 35171 +2 - Partials 2288 2291 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

woocommerce / woocommerce-android