Closed backwardstruck closed 1 week ago
@kidinov this is targeted at 18.7 but can go into 18.8 if I don't merge in time.
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
App Name | WooCommerce Android | |
Flavor | Jalapeno | |
Build Type | Debug | |
Commit | 46e0e7c10cfee242f74a58ea04c95bb239f28a1f | |
Direct Download | woocommerce-prototype-build-pr11532-46e0e7c.apk |
Attention: Patch coverage is 85.71429%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 40.47%. Comparing base (
663f191
) to head (46e0e7c
). Report is 16 commits behind head on trunk.
Files | Patch % | Lines |
---|---|---|
...ts/methodselection/ChangeDueCalculatorViewModel.kt | 85.71% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
If closing the test coverage gap noted by the Codecov Report for ChangeDueCalculatorFragment isn't planned to be addressed in this PR and isn't already covered by a ticket or task please file one as a reminder to get back to this later.
If closing the test coverage gap noted by the Codecov Report for ChangeDueCalculatorFragment isn't planned to be addressed in this PR and isn't already covered by a ticket or task please file one as a reminder to get back to this later.
Yes, I will address those in this ticket as there's more functionality to be added that will also require tests.
Overal lgtm! I left a few suggestions, please take a look
Thanks @kidinov This should be ready for review again now that I've pushed those changes.
Thanks @kidinov those are very good suggestions. Indeed, I forgot to move the classes to changeduecalculator
. I will address these in my next PR. They are listed in this new GH issue:
https://github.com/woocommerce/woocommerce-android/issues/11553
Addresses: #11525
Description
UI improvements for
ChangeDueCalculatorFragment
to provide a consistent title bar. This is the first PR for the GH issue, which contains other tasks.Testing instructions
OTHER_PAYMENT_METHODS
FFRELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.