[Mobile Payments] Fix pay in person learn more link

AnirudhBhat commented 1 month ago

Closes: #12729

Description

This PR fixes the incorrect "Learn More" link for the Pay in Person option in the payments menu. Previously, we used two different links for WooCommerce Payments and the Stripe payment gateway, but the content at these URLs had moved, resulting in irrelevant content being displayed. Now, a single URL is used, providing the correct information for both payment gateways.

Steps to reproduce

Navigate to payments menu (More menu -> Payments)
Click on learn more link under the Pay in Person option
Ensure relevant page about cash on delivery is opened.

The tests that have been performed

Tested that the URL content is proper for Pay in Person option.

Images/gif

https://github.com/user-attachments/assets/96aad8fd-2ab2-42f9-9644-f03ec02c628f

[x] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

[ ] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
[ ] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
[ ] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

dangermattic commented 1 month ago

	1 Warning
:warning:	This PR is assigned to the milestone 20.8. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	34db50bbf402b4290f05ee85016bc1367c09bbee
	Direct Download	`woocommerce-wear-prototype-build-pr12786-34db50b.apk`

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	34db50bbf402b4290f05ee85016bc1367c09bbee
	Direct Download	`woocommerce-prototype-build-pr12786-34db50b.apk`

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.84%. Comparing base (dd1bf89) to head (7afe350).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## trunk #12786 +/- ## ============================================ - Coverage 40.84% 40.84% -0.01% + Complexity 5744 5742 -2 ============================================ Files 1236 1236 Lines 69687 69685 -2 Branches 9663 9662 -1 ============================================ - Hits 28466 28465 -1 Misses 38596 38596 + Partials 2625 2624 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

woocommerce / woocommerce-android