Check black flagged websites on app launch

hichamboushaba commented 1 month ago

Closes: #12789 Closes: #12790

Depends on #12788

Description

This PR adds logic to fetch the site status from the WCPom endpoint on app launch to determine if the site is suspended or not, and then update the corresponding flags, this will ensure two cases:

If a suspended site gets approved later, we'll show them the Jeptack upsells from inside.
If a site gets suspended, then we'll hide the Jetpack installation upsells.

Steps to reproduce

DM me to share with a suspended website (or the steps to create one)
Open the app and sign in to the site.
DM me to share steps to mark the site as not suspended.
Open the app.

Testing information

At step 4, confirm that the Jetpack upsells are shown again in the app.

Important: the Jetpack upsells might not show exactly on first launch if the fetch took a little bit long, but they will appear when changing the screen and going back, I think that this is fine for this use case and that listening to the preference to update the UI would be an overkill, a site being suspended or unsuspended wouldn't be a frequent change anyway, let me know what you think.

The tests that have been performed

^

[ ] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

[x] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
[x] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
[x] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

dangermattic commented 1 month ago

	1 Warning
:warning:	This PR is assigned to the milestone 20.8. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

	1 Message
:book:	This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed: The tracks events must be validated in the Tracks system. Verify the internal Tracks spreadsheet has also been updated. Please consider registering any new events. The PR must be assigned the category: tracks label.

1 Message

:book:

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

The tracks events must be validated in the Tracks system.
Verify the internal Tracks spreadsheet has also been updated.
Please consider registering any new events.
The PR must be assigned the category: tracks label.

Generated by :no_entry_sign: Danger

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	05655fc9871be01ec1b1084fd1f059510ba28587
	Direct Download	`woocommerce-wear-prototype-build-pr12792-05655fc.apk`

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	05655fc9871be01ec1b1084fd1f059510ba28587
	Direct Download	`woocommerce-prototype-build-pr12792-05655fc.apk`

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 40.86%. Comparing base (c0d7adb) to head (05655fc). Report is 10 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...erce/android/ui/sitepicker/SitePickerRepository.kt	0.00%	5 Missing :warning:
...ain/kotlin/com/woocommerce/android/SiteObserver.kt	95.00%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## trunk #12792 +/- ## ============================================ + Coverage 40.80% 40.86% +0.05% - Complexity 5753 5765 +12 ============================================ Files 1237 1237 Lines 69833 69852 +19 Branches 9699 9706 +7 ============================================ + Hits 28498 28545 +47 + Misses 38706 38672 -34 - Partials 2629 2635 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

woocommerce / woocommerce-android