woocommerce / woocommerce-android

WooCommerce Android app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
277 stars 135 forks source link

[Bug] Text hidden behind checkbox in the "change due calculator" screen #12808

Closed samiuelson closed 4 weeks ago

samiuelson commented 1 month ago

Fix for UI glitch in "Change due calculator" screen

Closes: #12662

Description

This PR fixes UI issue in "Change due calculator" screen–the label was overlapping with the checkbox certain scenarios (locales/screen widhts):

Screenshot 2024-10-22 at 13 39 11

The bug was caused by the Row's horizontalAlignment setting.

Steps to reproduce

To reproduce the bug, modify the string length or adjust screen width and observe the checkbox overlapping the text as shown in the screenshot above.

Testing information

Tested on Google Pixel 7 Pro, Android 14 and in Compose previews of various screen sizes and orientations.

The tests that have been performed

  1. Reproduced the original issue by adjusting the text of the label
  2. Verified that updated horizontal alignment settings fix the issue on various screen sizes

Images/gif

After

Screenshot 2024-10-22 at 13 23 41 Screenshot 2024-10-22 at 13 23 26

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

wpmobilebot commented 1 month ago
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitb98ed737b3ef45b42df7c5fd8ec35dae0ddd5853
Direct Downloadwoocommerce-wear-prototype-build-pr12808-b98ed73.apk
wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitb98ed737b3ef45b42df7c5fd8ec35dae0ddd5853
Direct Downloadwoocommerce-prototype-build-pr12808-b98ed73.apk