Fix crash on site picker for accounts without woo sites

irfano commented 1 month ago

Closes: #10553

Description

This fixes a crash that occurs when using the wrong account that does not have any Woo sites. When the mismatch screen is displayed, the primary button on the site picker screen was always visible. This PR checks existing woo sites to set the visibility of the primary button.

Steps to reproduce

Open the login flow and enter a Woo site address.
Enter your WP account that does not have any Woo sites.
When the jetpack connection error screen is displayed, navigate back.
On the site picker screen tap the "Continue" button.

Testing information

[ ] Login with an account that has Woo site (but wrong site)
[ ] Login with an account without any Woo sites.

The tests that have been performed

I tested the mismatch account screen with accounts that have Woo sites and accounts without any Woo sites.

Images/gif

before	after

[x] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

[ ] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
[ ] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
[ ] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

dangermattic commented 1 month ago

	1 Warning
:warning:	This PR is assigned to the milestone 21.0. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	a96e66a8f22f85bd44c8b95c8ee32672459b0238
	Direct Download	`woocommerce-wear-prototype-build-pr12812-a96e66a.apk`

wpmobilebot commented 4 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	a96e66a8f22f85bd44c8b95c8ee32672459b0238
	Direct Download	`woocommerce-prototype-build-pr12812-a96e66a.apk`

codecov-commenter commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.86%. Comparing base (e1ef2aa) to head (a96e66a). Report is 17 commits behind head on trunk.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## trunk #12812 +/- ## ========================================= Coverage 40.86% 40.86% - Complexity 5765 5770 +5 ========================================= Files 1237 1237 Lines 69857 69857 Branches 9707 9707 ========================================= + Hits 28545 28549 +4 Misses 38677 38677 + Partials 2635 2631 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sentry-io[bot] commented 2 weeks ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️ NullPointerException com.woocommerce.android.ui.sitepicker.SitePicke... View Issue

_{Did you find this useful? React with a 👍 or 👎}

irfano commented 2 weeks ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️ NullPointerException com.woocommerce.android.ui.sitepicker.SitePicke... View Issue

@atorresveiga, this crash was introduced in "20.9-rc-1." I'll monitor the trend, and if it appears significant, I may target the beta branch. Just keeping you informed since you’re managing the release.

woocommerce / woocommerce-android