Closed ThomazFB closed 4 weeks ago
App Name | WooCommerce-Wear Android | |
Platform | ⌚️ Wear OS | |
Flavor | Jalapeno | |
Build Type | Debug | |
Commit | ad4166efb5005dec4514554dd2b223bd156b6c16 | |
Direct Download | woocommerce-wear-prototype-build-pr12814-ad4166e.apk |
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
App Name | WooCommerce Android | |
Platform | 📱 Mobile | |
Flavor | Jalapeno | |
Build Type | Debug | |
Commit | ad4166efb5005dec4514554dd2b223bd156b6c16 | |
Direct Download | woocommerce-prototype-build-pr12814-ad4166e.apk |
Attention: Patch coverage is 65.00000%
with 7 lines
in your changes missing coverage. Please review.
Project coverage is 40.86%. Comparing base (
e1ef2aa
) to head (ad4166e
). Report is 14 commits behind head on trunk.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Summary
Fix issue #12623 by making sure that the Product selection screen never displays the
filter
button when the selector is already being opened from a Filtering flow.The Product selection screen is used in multiple areas of the app, like Order Editing and Creation, and due to it's nature, it also features a filter button to enhance the search. But the main Product Filter inside the Product list screen can also call the Product Selector screen, causing a weird scenario where we display a filter button inside an already filtering flow.
To mitigate this issue, the Product selection screen is aware if it was called from a filtering flow or not, and hide the filter button when it's not needed.
Screen Capture
https://github.com/user-attachments/assets/7189dbc4-1e99-4a5d-93a5-e2155ddef555
How to Test
Scenario 1
Filters
option and go to theProducts
sub-optionfilter
button is not visible anywhere thereScenario 2
Add Product
optionfilter
button is visible and works as expectedUpdate release notes:
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: