[Bug] Remove new lines from subtitle strings in "Collect Payment has moved" bottom sheet

samiuelson commented 4 weeks ago

Closes: #12666

Description

This PR attempts to fix issue with odd text formatting in some locales in the "Collect Payment has moved" bottom sheet rationale.

Steps to reproduce

🧭 Path: More menu > Payments > Collect Payment > Bottom sheet

Certain translations of the following english/default strings contain \n in wrong places:

<string name="order_creation_simple_payment_migration_message_one">We’ve combined payment collection with\norder creation, making it more accessible\nand more powerful.</string>
<string name="order_creation_simple_payment_migration_message_two">To set a payment amount, add\na custom amount to your new order.</string>

e.g.: <string name="order_creation_simple_payment_migration_message_one">Hemos combinado el cobro de pagos con\nla creación de pedidos, de manera que sea una función más accesible\ny potente.</string>

Testing information

The problem is due to a bug in translation – the \ns were put in weird places by translators, resulting in text formatting glitches:

As per my observation of different screen sizes, it's sufficient to remove the \n from these texts completely, because texts are quite well-formatted by default.

Modifying the original strings, by removing \ns from them will trigger update of their translations during release which should resolve the issue.

The tests that have been performed

I tested the text formatting on various screen sizes and orientations. Devices: Pixel 7 pro, Samsung S9 Tab FE; Android 14

Images/gif

After the change:

[x] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

[x] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
[x] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
[x] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

dangermattic commented 4 weeks ago

	1 Warning
:warning:	This PR is assigned to the milestone 21.0. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

wpmobilebot commented 4 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	075f26bfc607fe7acedbbca1608220afb7c8d904
	Direct Download	`woocommerce-wear-prototype-build-pr12815-075f26b.apk`

wpmobilebot commented 4 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	075f26bfc607fe7acedbbca1608220afb7c8d904
	Direct Download	`woocommerce-prototype-build-pr12815-075f26b.apk`

woocommerce / woocommerce-android