woocommerce / woocommerce-android

WooCommerce Android app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
277 stars 135 forks source link

Creating shipping label: Shipment details bottom sheet & Address card #12816

Closed atorresveiga closed 1 month ago

atorresveiga commented 1 month ago

Part of: #12281

Description

The changes in this PR include the shipment details bottom sheet and the Address card implementation. All the changes in this PR are focused on UI, and the data used in the screens is mocked. On a different PR, I will connect this UI with real data.

Considering that the Address card will be worked on at a different milestone, the current implementation does not include the Ship from selection or the edit Ship to address.

I didn't work on the shipment details title animation in this PR. I'm planning some time to work on this animation after the connection with real data

Testing information

  1. Create an Order with the processing status on a store that can create shipping labels
  2. Tap on Orders
  3. Tap on the order created on step 1
  4. Tap con create shipping labels
  5. Check that Shipment details card is displayed at the bottom of the screen
  6. Tap on/Drag up Shipment details
  7. Check that the bottom sheets expand and the Address card is visible
  8. Tap on/Drag down the bottom sheet handle
  9. Check that the bottom sheet collapses

The tests that have been performed

  1. Test that the UI interaction works as expected

Images/gif

https://github.com/user-attachments/assets/7037cbeb-0c58-44bb-9426-2fc5fed31b5e

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

dangermattic commented 1 month ago
1 Warning
:warning: This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by :no_entry_sign: Danger

wpmobilebot commented 1 month ago
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit4703482a800666f8e7883c3c6a8caee3df638f03
Direct Downloadwoocommerce-wear-prototype-build-pr12816-4703482.apk
wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit4703482a800666f8e7883c3c6a8caee3df638f03
Direct Downloadwoocommerce-prototype-build-pr12816-4703482.apk
codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 145 lines in your changes missing coverage. Please review.

Project coverage is 40.60%. Comparing base (9bd14ac) to head (4703482). Report is 23 commits behind head on trunk.

Files with missing lines Patch % Lines
...oid/ui/orders/wooshippinglabels/ShipmentDetails.kt 0.00% 145 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #12816 +/- ## ============================================ - Coverage 40.69% 40.60% -0.09% Complexity 5771 5771 ============================================ Files 1240 1241 +1 Lines 70169 70314 +145 Branches 9767 9794 +27 ============================================ Hits 28552 28552 - Misses 38985 39130 +145 Partials 2632 2632 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.