Experimental ipp observer facade 2

samiuelson commented 1 month ago

Closes: #

[ ] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

[ ] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
[ ] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
[ ] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

dangermattic commented 1 month ago

	7 Errors
:no_entry_sign:	Please add tests for class `CardReaderPaymentController` (or add `unit-tests-exemption` label to ignore this).
:no_entry_sign:	Please add tests for class `IppPaymentStateObserver` (or add `unit-tests-exemption` label to ignore this).
:no_entry_sign:	Please add tests for class `PaymentFlowState` (or add `unit-tests-exemption` label to ignore this).
:no_entry_sign:	Please add tests for class `IppPaymentUIConfig` (or add `unit-tests-exemption` label to ignore this).
:no_entry_sign:	Please add tests for class `IppPaymentUI` (or add `unit-tests-exemption` label to ignore this).
:no_entry_sign:	Please add tests for class `Custom` (or add `unit-tests-exemption` label to ignore this).
:no_entry_sign:	Please add tests for class `WooPosCardReaderState` (or add `unit-tests-exemption` label to ignore this).

	1 Warning
:warning:	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

	1 Message
:book:	This PR is still a Draft: some checks will be skipped.

Generated by :no_entry_sign: Danger

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	1fa690bb0c3536454d1279bdb6df97ddecd77536
	Direct Download	`woocommerce-wear-prototype-build-pr12830-1fa690b.apk`

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	1fa690bb0c3536454d1279bdb6df97ddecd77536
	Direct Download	`woocommerce-prototype-build-pr12830-1fa690b.apk`