woocommerce / woocommerce-android

WooCommerce Android app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
277 stars 135 forks source link

Introduce AVIF displaying support #12835

Closed ThomazFB closed 3 weeks ago

ThomazFB commented 3 weeks ago

Summary

Depends on https://github.com/wordpress-mobile/WordPress-Utils-Android/pull/154

Fix issue #12810 by introducing an update from the PhotonUtils in the WordPress-Utils-Android and adding the AVIF integration to the Glide dependency.

There's no code to cover with unit tests in the PR changelog.

How to Test

To test this, you will need at least one product configured with an image in the AVIF format. I highly recommend using this one from an open source AVIF samples repository.

Please bear in mind that the AVIF format supports multiple different metadata and configurations, and the Android OS doesn't support them all, some AVIF images will load, while others may not.

The testing should ensure that sections like Orders, Product Details, Product List, Product Gallery, and related sections successfully display the image in the AVIF format.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

dangermattic commented 3 weeks ago
1 Warning
:warning: This PR is assigned to the milestone 21.0. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

wpmobilebot commented 3 weeks ago

Project dependencies changes

The following changes in project dependencies were detected (configuration vanillaReleaseRuntimeClasspath):

list ``` New Dependencies com.github.bumptech.glide:avif-integration:4.16.0 org.aomedia.avif.android:avif:0.11.1.3c786d2 Upgraded Dependencies org.wordpress:utils:3.15.0, (changed from 3.5.0) ```
tree ```diff -+--- org.wordpress:utils:3.5.0 -| +--- org.apache.commons:commons-text:1.10.0 -| | \--- org.apache.commons:commons-lang3:3.12.0 -| +--- com.android.volley:volley:1.2.0 -| +--- com.google.android.material:material:1.2.1 -> 1.12.0 (*) -| +--- androidx.swiperefreshlayout:swiperefreshlayout:1.1.0 -| | +--- androidx.annotation:annotation:1.1.0 -> 1.8.0 (*) -| | +--- androidx.core:core:1.1.0 -> 1.13.1 (*) -| | \--- androidx.interpolator:interpolator:1.0.0 (*) -| +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*) -| +--- org.greenrobot:eventbus:3.3.1 -| | \--- org.greenrobot:eventbus-java:3.3.1 -| +--- androidx.core:core-ktx:1.5.0 -> 1.13.1 (*) -| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.6.10 -> 1.9.10 (*) ++--- org.wordpress:utils:3.15.0 +| +--- org.apache.commons:commons-text:1.10.0 +| | \--- org.apache.commons:commons-lang3:3.12.0 +| +--- com.google.android.material:material:1.2.1 -> 1.12.0 (*) +| +--- androidx.swiperefreshlayout:swiperefreshlayout:1.1.0 +| | +--- androidx.annotation:annotation:1.1.0 -> 1.8.0 (*) +| | +--- androidx.core:core:1.1.0 -> 1.13.1 (*) +| | \--- androidx.interpolator:interpolator:1.0.0 (*) +| +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*) +| +--- org.greenrobot:eventbus:3.3.1 +| | \--- org.greenrobot:eventbus-java:3.3.1 +| +--- org.greenrobot:eventbus-java:3.3.1 +| +--- androidx.core:core:1.5.0 -> 1.13.1 (*) +| \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 1.9.25 (*) \--- com.automattic.tracks:experimentation:5.0.0 - \--- org.wordpress:utils:2.3.0 -> 3.5.0 (*) + \--- org.wordpress:utils:2.3.0 -> 3.15.0 (*) +\--- com.github.bumptech.glide:avif-integration:4.16.0 + +--- com.github.bumptech.glide:glide:4.16.0 (*) + +--- org.aomedia.avif.android:avif:0.11.1.3c786d2 + \--- com.google.guava:guava:28.1-android -> 33.1.0-android (*) ```
wpmobilebot commented 3 weeks ago
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commita37683d244438c5900648be39c5fb491e3f9115a
Direct Downloadwoocommerce-wear-prototype-build-pr12835-a37683d.apk
wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commita37683d244438c5900648be39c5fb491e3f9115a
Direct Downloadwoocommerce-prototype-build-pr12835-a37683d.apk